Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#24427 closed defect (bug) (invalid)

Media uploader icon for media post formats missing HiDPI

Reported by: jakemgold Owned by:
Milestone: Priority: normal
Severity: major Version: 3.6
Component: Post Formats Keywords: has-patch
Focuses: Cc:


Media upload icon in the post format box (image, video, audio) lacked a HiDPI / Retina version.

I've included a patch that addresses it. Rather than adding yet another standalone media upload icon I've modified the CSS and added a required div in audio / video format version (that mirrors the image version - more on that in a moment) that now uses the same media upload icons (32px and 64px/2x) used in the heading on the Media admin screen (icons32.png / icons-32-2x.png). Honestly, it might be smart for us to eliminate the standalone media icons in favor of this elsewhere, too (i.e. the media upload button above the editor), in the interests of removing minor repetitive clutter.

I'm entirely open to building a simpler patch that simply adds another standalone media icon, if preferred.

Some other rather anal considerations:

  • As before my patch, I'm only using the "gray" (fresh) version of the icon. I stuck with the approach from before my patch, but I'm wondering if this should be pulled out of wp-admin.css and moved into the fresh / classic stylesheets (along with an alternate background color)... Could argue it both ways since the "add media" button near the editor is only in gray.
  • Inside the image post format div HTML is an h3 that says "Drop image file to upload" - since it's hidden, I'm not sure if that's a relic of some sort or there for some usability reason, but it's not present in the other post format media upload fields. I had to add the wrapping div back (since my new icon needs a box, coming from a sprite), but chose not to add any h3 / copy, mostly to avoid opening up new translation needs ("Drop *video* file to upload", etc).

Attachments (1)

hidpi-post-format-media-icon.diff (2.2 KB) - added by jakemgold 7 years ago.
Adds HiDPI media upload icon for post formats

Download all attachments as: .zip

Change History (3)

7 years ago

Adds HiDPI media upload icon for post formats

#1 @SergeyBiryukov
7 years ago

  • Component changed from General to Post Formats
  • Milestone changed from Awaiting Review to 3.6

#2 @ocean90
7 years ago

  • Milestone 3.6 deleted
  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.