WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#24437 closed defect (bug) (fixed)

No need to escape anchor text

Reported by: zeo Owned by: SergeyBiryukov
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: Cc:
PR Number:

Description

Anchor text is not an attribute. esc_attr is not needed here http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-posts-list-table.php#L1054.

See patch.

Attachments (1)

24437.patch (1.2 KB) - added by zeo 6 years ago.

Download all attachments as: .zip

Change History (5)

#1 follow-up: @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 3.6

Looks like the title attribute is redundant, it can probably be removed too.

#2 in reply to: ↑ 1 @nacin
6 years ago

Replying to SergeyBiryukov:

Looks like the title attribute is redundant, it can probably be removed too.

Yup.

@zeo
6 years ago

#3 @zeo
6 years ago

Patch updated. It removes the title attr for Cancel too.

#4 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 24380:

Remove unnecessary esc_attr() call and redundant title attributes. props zeo. fixes #24437.

Note: See TracTickets for help on using tickets.