Visit theme/plugin/author homepage vs Visit theme/plugin/author site

[zeo]

See:

1) wp-admin/includes/class-wp-ms-themes-list-table.php: Visit theme homepage and Visit Theme Site

2) wp-admin/includes/class-wp-plugins-list-table.php: Visit plugin site (2 same strings)

3) wp-admin/includes/plugin.php: Visit plugin homepage

4) wp-admin/includes/class-wp-plugins-list-table.php, wp-admin/includes/plugin.php, wp-includes/class-wp-theme.php: Visit author homepage

These strings should be consistent but I'm not sure whether to go with site or homepage. I also suggest remove the redundant title attribute in 2).

FYI, the strings only appear in the files that listed above.

[sabernhardt]

Updates:

• In changeset:28673 (ticket:26554), the title attributes were removed from class-wp-plugins-list-table.php, plugin.php and class-wp-theme.php.
• Then changeset:35924 replaced the title attribute in class-wp-ms-themes-list-table.php with an ARIA label of "Visit [theme name] homepage" for context within a list of links.

That aria-label might be better as "Visit theme site for [theme name]" so its beginning matches the visible link text (at least in English). 24442.diff​ edits the theme site link label (network themes admin screen), and it adds a similar label on the plugin URI link when the plugin is outside the directory.

[audrasjb]

The change proposed by @sabernhardt looks legitimate to me and the patch applies cleanly against trunk. Marking this for commit. Since all the other issues were previously addressed, I believe this change will close this ticket.

[SergeyBiryukov]

In 51795:

Accessibility: Administration: Improve aria-label on network admin Themes screen.

This ensures that the beginning of the label matches the visible link text.

Add a similar label for the plugin URI link on the Plugins screen when the plugin is outside of the directory.

Follow-up to [28673], [28706], [35924].

Props sabernhardt, zeo, audrasjb.
Fixes #24442.