Opened 12 years ago
Closed 3 years ago
#24442 closed enhancement (fixed)
Visit theme/plugin/author homepage vs Visit theme/plugin/author site
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Administration | Keywords: | has-patch commit |
Focuses: | accessibility, ui-copy | Cc: |
Description (last modified by )
See:
1) wp-admin/includes/class-wp-ms-themes-list-table.php: Visit theme homepage and Visit Theme Site
2) wp-admin/includes/class-wp-plugins-list-table.php: Visit plugin site (2 same strings)
3) wp-admin/includes/plugin.php: Visit plugin homepage
4) wp-admin/includes/class-wp-plugins-list-table.php, wp-admin/includes/plugin.php, wp-includes/class-wp-theme.php: Visit author homepage
These strings should be consistent but I'm not sure whether to go with site or homepage. I also suggest remove the redundant title
attribute in 2).
FYI, the strings only appear in the files that listed above.
Attachments (1)
Change History (9)
#4
@
4 years ago
- Component changed from Upgrade/Install to Administration
- Description modified (diff)
- Focuses accessibility added
- Keywords has-patch added; dev-feedback i18n-change removed
- Milestone set to Awaiting Review
This ticket was mentioned in Slack in #accessibility by sabernhardt. View the logs.
4 years ago
#7
@
3 years ago
- Keywords commit added
- Owner set to audrasjb
- Status changed from new to accepted
The change proposed by @sabernhardt looks legitimate to me and the patch applies cleanly against trunk. Marking this for commit
. Since all the other issues were previously addressed, I believe this change will close this ticket.
Updates:
That
aria-label
might be better as "Visit theme site for [theme name]" so its beginning matches the visible link text (at least in English). 24442.diff edits the theme site link label (network themes admin screen), and it adds a similar label on the plugin URI link when the plugin is outside the directory.