WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 6 weeks ago

#24442 closed enhancement (fixed)

Visit theme/plugin/author homepage vs Visit theme/plugin/author site

Reported by: zeo Owned by: audrasjb
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch commit
Focuses: accessibility, ui-copy Cc:

Description (last modified by sabernhardt)

See:

1) wp-admin/includes/class-wp-ms-themes-list-table.php: Visit theme homepage and Visit Theme Site

2) wp-admin/includes/class-wp-plugins-list-table.php: Visit plugin site (2 same strings)

3) wp-admin/includes/plugin.php: Visit plugin homepage

4) wp-admin/includes/class-wp-plugins-list-table.php, wp-admin/includes/plugin.php, wp-includes/class-wp-theme.php: Visit author homepage

These strings should be consistent but I'm not sure whether to go with site or homepage. I also suggest remove the redundant title attribute in 2).

FYI, the strings only appear in the files that listed above.

Attachments (1)

24442.diff (1.4 KB) - added by sabernhardt 4 months ago.

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
8 years ago

  • Component changed from I18N to Text Changes

#2 @chriscct7
6 years ago

  • Keywords i18n-change added; 2nd-opinion removed

#3 @garrett-eclipse
21 months ago

  • Component changed from Text Changes to Upgrade/Install
  • Focuses ui-copy added

@sabernhardt
4 months ago

#4 @sabernhardt
4 months ago

  • Component changed from Upgrade/Install to Administration
  • Description modified (diff)
  • Focuses accessibility added
  • Keywords has-patch added; dev-feedback i18n-change removed
  • Milestone set to Awaiting Review

Updates:

  • In changeset:28673 (ticket:26554), the title attributes were removed from class-wp-plugins-list-table.php, plugin.php and class-wp-theme.php.
  • Then changeset:35924 replaced the title attribute in class-wp-ms-themes-list-table.php with an ARIA label of "Visit [theme name] homepage" for context within a list of links.

That aria-label might be better as "Visit theme site for [theme name]" so its beginning matches the visible link text (at least in English). 24442.diff edits the theme site link label (network themes admin screen), and it adds a similar label on the plugin URI link when the plugin is outside the directory.

This ticket was mentioned in Slack in #accessibility by sabernhardt. View the logs.


4 months ago

#6 @sabernhardt
4 months ago

  • Milestone changed from Awaiting Review to 5.9

#7 @audrasjb
6 weeks ago

  • Keywords commit added
  • Owner set to audrasjb
  • Status changed from new to accepted

The change proposed by @sabernhardt looks legitimate to me and the patch applies cleanly against trunk. Marking this for commit. Since all the other issues were previously addressed, I believe this change will close this ticket.

#8 @SergeyBiryukov
6 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 51795:

Accessibility: Administration: Improve aria-label on network admin Themes screen.

This ensures that the beginning of the label matches the visible link text.

Add a similar label for the plugin URI link on the Plugins screen when the plugin is outside of the directory.

Follow-up to [28673], [28706], [35924].

Props sabernhardt, zeo, audrasjb.
Fixes #24442.

Note: See TracTickets for help on using tickets.