![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 13 years ago
Closed 5 years ago
#24442 closed enhancement (fixed)
Visit theme/plugin/author homepage vs Visit theme/plugin/author site
| Reported by: | zeo | Owned by: | audrasjb |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.9 |
| Component: | Administration | Version: | |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: | accessibility, ui-copy |
Description (last modified by )
See:
1) wp-admin/includes/class-wp-ms-themes-list-table.php: Visit theme homepage and Visit Theme Site
2) wp-admin/includes/class-wp-plugins-list-table.php: Visit plugin site (2 same strings)
3) wp-admin/includes/plugin.php: Visit plugin homepage
4) wp-admin/includes/class-wp-plugins-list-table.php, wp-admin/includes/plugin.php, wp-includes/class-wp-theme.php: Visit author homepage
These strings should be consistent but I'm not sure whether to go with site or homepage. I also suggest remove the redundant title attribute in 2).
FYI, the strings only appear in the files that listed above.
Attachments (1)
Change History (9)
#4
@
5 years ago
- Component Upgrade/Install → Administration
- Description modified (diff)
- Focuses accessibility added
- Keywords has-patch added; dev-feedback i18n-change removed
- Milestone → Awaiting Review
This ticket was mentioned in Slack in #accessibility by sabernhardt. View the logs.
5 years ago
#7
@
5 years ago
- Keywords commit added
- Owner set to
- Status new → accepted
The change proposed by @sabernhardt looks legitimate to me and the patch applies cleanly against trunk. Marking this for commit. Since all the other issues were previously addressed, I believe this change will close this ticket.
Updates:
That
aria-labelmight be better as "Visit theme site for [theme name]" so its beginning matches the visible link text (at least in English). 24442.diff edits the theme site link label (network themes admin screen), and it adds a similar label on the plugin URI link when the plugin is outside the directory.