WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 4 of Ticket #24442


Ignore:
Timestamp:
06/12/2021 07:52:59 PM (3 years ago)
Author:
sabernhardt
Comment:

Updates:

  • In changeset:28673 (ticket:26554), the title attributes were removed from class-wp-plugins-list-table.php, plugin.php and class-wp-theme.php.
  • Then changeset:35924 replaced the title attribute in class-wp-ms-themes-list-table.php with an ARIA label of "Visit [theme name] homepage" for context within a list of links.

That aria-label might be better as "Visit theme site for [theme name]" so its beginning matches the visible link text (at least in English). 24442.diff​ edits the theme site link label (network themes admin screen), and it adds a similar label on the plugin URI link when the plugin is outside the directory.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #24442

    • Property Keywords has-patch added; 2nd-opinion dev-feedback removed
    • Property Focuses accessibility ui-copy added
    • Property Component changed from I18N to Administration
    • Property Milestone changed from to Awaiting Review

  • Ticket #24442 – Description

    initial v4  
    11See:
    22
    3 1) http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-ms-themes-list-table.php#L334: '''Visit theme homepage''' and '''Visit Theme Site'''
     31) [https://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-ms-themes-list-table.php?rev=24379#L334 wp-admin/includes/class-wp-ms-themes-list-table.php]: '''Visit theme homepage''' and '''Visit Theme Site'''
    44
    5 2) http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-plugins-list-table.php#L418: '''Visit plugin site''' (2 same strings)
     52) [https://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-plugins-list-table.php?rev=24379#L418 wp-admin/includes/class-wp-plugins-list-table.php]: '''Visit plugin site''' (2 same strings)
    66
    7 3) http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/plugin.php#L160: '''Visit plugin homepage'''
     73) [https://core.trac.wordpress.org/browser/trunk/wp-admin/includes/plugin.php?rev=24379#L160 wp-admin/includes/plugin.php]: '''Visit plugin homepage'''
    88
    9 4) http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-plugins-list-table.php#L414, http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/plugin.php#L163, http://core.trac.wordpress.org/browser/trunk/wp-includes/class-wp-theme.php#L654: '''Visit author homepage'''
     94) [https://core.trac.wordpress.org/browser/trunk/wp-admin/includes/class-wp-plugins-list-table.php?rev=24379#L414 wp-admin/includes/class-wp-plugins-list-table.php], [https://core.trac.wordpress.org/browser/trunk/wp-admin/includes/plugin.php?rev=24379#L163 wp-admin/includes/plugin.php], [https://core.trac.wordpress.org/browser/trunk/wp-includes/class-wp-theme.php?rev=24379#L655 wp-includes/class-wp-theme.php]: '''Visit author homepage'''
    1010
    1111These strings should be consistent but I'm not sure whether to go with '''site''' or '''homepage'''. I also suggest remove the redundant {{{title}}} attribute in 2).