#24469 closed defect (bug) (fixed)
Twenty Thirteen: remove all post_format_* and the_remaining_content() function calls
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.6 | Priority: | high |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch needs-testing |
Focuses: | Cc: |
Description
Related to #24452.
Twenty Thirteen needs to use only the_content()
and not the newly introduced post format content parsing functions.
Changes include:
- Video and image widths go from 724 to 604 width, and each will be below the post title (in post_content) and not separately, above.
- Audio: just use
the_content
and shouldn't change too much visually - Galleries: use the lower-level "grab first gallery" function instead of
the_post_format_gallery
- Link: URL grabber is staying in core
- Chat: just goes to
the_content
- Quote: simplify CSS rules to just expected "normal" markup
- Aside, Status work as they do now
Attachments (4)
Change History (13)
#2
@
12 years ago
Great start. Bummer to lose the visual editor styles for post formats.
I think get_post_gallery()
is staying around, so we can use echo get_post_gallery()
in the template.
We can use get_content_url()
still.
#3
@
12 years ago
.1 patch, building on obenland's first patch:
- Clean up some JS used with removed Quote HTML output
- Use
echo get_post_gallery()
instead of needingtwentythirteen_featured_gallery()
- Use
get_content_url()
for grabbing the link for Link post format - One global variable call in
content_width
filter
#4
@
12 years ago
Patch refreshed to fix PHP error:
PHP Strict Standards: Only variables should be passed by reference in /Applications/MAMP/htdocs/wordpress-trunk/wp-content/themes/twentythirteen/functions.php on line 439
#5
@
12 years ago
Everything is looking OK so far in testing.
Quotes: with inconsistent markup we're going to be all over the map. Probably worth seeing the two or there most common patterns and styling them. I'd also be up for keeping the figure
selectors around in case an author uses HTML5 correctly. A nice reward!
Images: my test site (and anyone running Twenty Thirteen on a self-hosted blog) has a lot of empty image posts now. Do we have a way to migrate them to insert the image into post content?
First stab, needs testing and probably some refining.