Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#24471 closed defect (bug) (fixed)

Twenty Thirteen blockquote undoes italics from original quote

Reported by: johnbierly's profile johnbierly Owned by: lancewillett's profile lancewillett
Milestone: 3.6 Priority: low
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

In the attached screen shots, the word "there" in the quote in the bottom line is italicized in the quoted text.

In the shot from the Ryu theme (which italicizes its blockquotes), "there" becomes un-italicized, thus setting it off from the rest of the text as the original author intended.

In the shot from Twenty Thirteen, it's still italic just as all the other words are.

Not sure if this is a bug or just a stylistic thing, and it's a rare case.

(Twenty Twelve does the same thing as Thirteen, actually.)

Attachments (5)

italics2.png (56.9 KB) - added by johnbierly 11 years ago.
Ryu
italics1.png (31.5 KB) - added by johnbierly 11 years ago.
Twenty Thirteen
24471.patch (400 bytes) - added by lancewillett 11 years ago.
quote-italic-roman.png (58.0 KB) - added by lancewillett 11 years ago.
24471.2.patch (1.0 KB) - added by lancewillett 11 years ago.

Download all attachments as: .zip

Change History (12)

@johnbierly
11 years ago

Ryu

@johnbierly
11 years ago

Twenty Thirteen

#1 @lancewillett
11 years ago

  • Milestone changed from Awaiting Review to 3.6

We could do something similar to Ryu, with:

blockquote em,
blockquote cite {
  font-style: normal;
}

#2 @lancewillett
11 years ago

  • Keywords has-patch 2nd-opinion ui-feedback added
  • Priority changed from normal to low

@lancewillett
11 years ago

#3 @obenland
11 years ago

Can we limit it to just ems? cite is frequently used for the quote source, which is supposed to stay in italics (it has also some other font styles added to it).

#4 @lancewillett
11 years ago

Sure, could be just em and i.

I don't like the way it looks, though–in Source Sans Bold the italic is 300 weight and looks lighter. The normal font (roman) is 400 weight.

See quote-italic-roman.png screenshot.

#5 @lancewillett
11 years ago

Obenland brought up a great point: we could load the 300 roman weight to fix the too-heavy font-weight here.

Also, noting that the 700 italic is also needed in case an author makes something bold and italic (very likely).

#6 @lancewillett
11 years ago

  • Keywords 2nd-opinion ui-feedback removed

#7 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24393:

Twenty Thirteen: better styles for blockquote italic and bold text. Fixes #24471.

Note: See TracTickets for help on using tickets.