Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #24472, comment 15


Ignore:
Timestamp:
06/29/2014 08:21:06 PM (11 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24472, comment 15

    initial v1  
    33Yeah, we don't need two filters. All default setting can be overridden with `$settings` and should always be set, no point to allow plugins to change them separately.
    44
    5 Thinking a filter only makes sense on the passed in `$settings` before they are merged with the defaults. It's inadvisable to filter the return value as we may need to add some per-processing similar to resetting `$set['editor_height']`, etc.
     5Thinking a filter only makes sense on the passed in `$settings` before they are merged with the defaults. It's inadvisable to filter the return value as we may need to add some pre-processing similar to resetting `$set['editor_height']`, etc.
    66
    77So this should probably be: