WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#24484 closed task (blessed) (fixed)

Lose the "remove" support for media extraction functions

Reported by: markjaquith Owned by: ocean90
Milestone: 3.6 Priority: high
Severity: blocker Version: 3.6
Component: Post Formats Keywords: needs-patch
Focuses: Cc:

Attachments (4)

24484.diff (16.8 KB) - added by markjaquith 4 years ago.
Rough first pass
24484.ut.patch (2.5 KB) - added by ocean90 3 years ago.
24484.patch (2.5 KB) - added by ocean90 3 years ago.
24484.ut.2.patch (1.3 KB) - added by ocean90 3 years ago.

Download all attachments as: .zip

Change History (13)

@markjaquith
4 years ago

Rough first pass

#1 @markjaquith
4 years ago

There's a rough first pass.

#2 @markjaquith
4 years ago

In 24400:

Lose content removal and splitting from the media extraction functions.

see #24484

#3 @greenshady
3 years ago

  • Cc justin@… added

Is there a particular reason this feature of the media functions is being removed? As a theme author, I found this functionality to be the most promising because I could extract the media on single posts and place it outside of the post content. It definitely opened up a lot of design opportunities that were hard to achieve before. Now, these functions only seem useful for archive-type pages where I might show the media + excerpt.

#4 @wonderboymusic
3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This can be added back in the plugin, when it exists

#5 @ocean90
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Unit tests need to be updated.

Last edited 3 years ago by ocean90 (previous) (diff)

@ocean90
3 years ago

#6 @ocean90
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

#7 @ocean90
3 years ago

  • Keywords needs-patch added
  • Resolution fixed deleted
  • Status changed from closed to reopened

We still have the remove support in get_content_url(). Should we remove it here too?

These lines should be removed:

#8 @markjaquith
3 years ago

  • Severity changed from critical to blocker

Yes.

@ocean90
3 years ago

@ocean90
3 years ago

#9 @ocean90
3 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from reopened to closed

In 24554:

Lose content removal and splitting from get_content_url(). And remove unneeded lines from [24400].

fixes #24484.

Note: See TracTickets for help on using tickets.