WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 3 months ago

#24495 closed defect (bug) (invalid)

thickbox's inline content will not trigger unless it is preceeded by an ampersand

Reported by: Clorith Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.5.1
Component: External Libraries Keywords:
Focuses: Cc:

Description

When using the built in thickbox, you are required to set up your links with an ampersand before the inlineId parameter or it will not pick this up.

This means that by calling inline content with <a href="#TB_inline?inlineID=foo-bar">, you will get an empty thickbox, where as calling <a href="#TB_inline?&inlineID=foo-bar"> it will function as intended and load the inline content for the thickbox.

Change History (4)

comment:1 c3mdigital7 months ago

  • Resolution set to wontfix
  • Status changed from new to closed

Since thickbox was abandoned and it's usage replaced with the new media model, core shouldn't maintain it beyond any security issues that may come up.

comment:2 SergeyBiryukov7 months ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Thickbox is still used for plugin and theme information in list tables.

comment:3 Clorith5 months ago

Thickbox is also the modal manager referenced in the Codex so I wouldn't be surprised if existing and potential future plugins are and will be trying to use it so long as it remains in core and no new alternative is made available to them.

Not sure if it's referenced in the upcoming handbooks or not but as it stands the Codex is still the go-to place for developer information.

comment:4 TobiasBg3 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from reopened to closed

I cannot reproduce this with current core Thickbox files: http://jsfiddle.net/AfAL6/1/

Note that it seems to be necessary to have another wrapping HTML element (like a <p>) in the element which has the desired inlineID.

Note: See TracTickets for help on using tickets.