Opened 12 years ago
Closed 11 years ago
#24497 closed enhancement (fixed)
Add CollegeHumor.com oEmbed Support
Reported by: | johnzanussi | Owned by: | johnbillion |
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Embeds | Keywords: | has-patch commit |
Focuses: | Cc: |
Description (last modified by )
http://www.collegehumor.com/api/oembed
URL scheme (videos):
http://www.collegehumor.com/video/*
API Endpoint:
http://www.collegehumor.com/oembed.{format}
Example:
http://www.collegehumor.com/oembed.xml?url=http%3A%2F%2Fwww.collegehumor.com%2Fvideo%2F3922232%2Fprank-war-7-the-half-million-dollar-shot
Supports discovery via <link> tags
Attachments (1)
Change History (13)
#4
@
11 years ago
Tested patch against 3.6. Works as expected. I'm intrigued by johnbillion's idea, and think it might be really cool to be able to modify these in a more fluid manner.
#6
@
11 years ago
- Keywords commit added
College Humor has way more of a presence/followers on the web than some other services we support. It is mainstream. I will wait for someone to 2nd this.
#7
@
11 years ago
- Owner set to johnbillion
- Resolution set to fixed
- Status changed from new to closed
In 28557:
#8
@
11 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Did anyone do a complete evaluation on this endpoint? Like URL structure of videos, protocols of both the endpoint and the video, whether it obeys widths and heights, looks good as both JSON and XML, and such...
#9
@
11 years ago
I tested this with three videos from the homepage with and without HTTPS. The widths were checked, the heights weren't. JSON response was checked, XML wasn't.
#10
@
11 years ago
- Resolution set to fixed
- Status changed from reopened to closed
XML works, just checked.
#11
@
11 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
According to #28507, CollegeHumor.com does not support SSL for its embeds. We should probably remove this until they do.
#12
@
11 years ago
- Resolution set to fixed
- Status changed from reopened to closed
Per IRC discussion, let's deal with SSL issues in #28507.
Here's an interesting thought. I wonder if the supported oEmbed providers should be loaded via a wordpress.org API call instead of being hardcoded into core?
This would allow providers to be added/removed more quickly in between releases. The current
oembed_providers
filter would remain in place of course for manual addition/removal of providers. Thoughts?