WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 11 months ago

#24497 closed enhancement (fixed)

Add CollegeHumor.com oEmbed Support

Reported by: johnzanussi Owned by: johnbillion
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch commit
Focuses: Cc:

Description (last modified by SergeyBiryukov)

http://www.collegehumor.com/api/oembed

URL scheme (videos):
http://www.collegehumor.com/video/*

API Endpoint:
http://www.collegehumor.com/oembed.{format}

Example:
http://www.collegehumor.com/oembed.xml?url=http%3A%2F%2Fwww.collegehumor.com%2Fvideo%2F3922232%2Fprank-war-7-the-half-million-dollar-shot

Supports discovery via <link> tags

Attachments (1)

24497.patch (844 bytes) - added by johnzanussi 2 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 @SergeyBiryukov2 years ago

  • Description modified (diff)

comment:2 @johnbillion2 years ago

Here's an interesting thought. I wonder if the supported oEmbed providers should be loaded via a wordpress.org API call instead of being hardcoded into core?

This would allow providers to be added/removed more quickly in between releases. The current oembed_providers filter would remain in place of course for manual addition/removal of providers. Thoughts?

@johnzanussi2 years ago

comment:3 @johnzanussi2 years ago

  • Keywords has-patch added; needs-patch removed

comment:4 @songsthatsaved22 months ago

Tested patch against 3.6. Works as expected. I'm intrigued by johnbillion's idea, and think it might be really cool to be able to modify these in a more fluid manner.

comment:5 @johnbillion13 months ago

  • Milestone changed from Awaiting Review to 4.0

Moving to 4.0 for consideration.

comment:6 @wonderboymusic12 months ago

  • Keywords commit added

College Humor has way more of a presence/followers on the web than some other services we support. It is mainstream. I will wait for someone to 2nd this.

comment:7 @johnbillion12 months ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 28557:

Add CollegeHumor.com oEmbed support. Fixes #24497. Props johnzanussi.

comment:8 @nacin12 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Did anyone do a complete evaluation on this endpoint? Like URL structure of videos, protocols of both the endpoint and the video, whether it obeys widths and heights, looks good as both JSON and XML, and such...

comment:9 @johnbillion12 months ago

I tested this with three videos from the homepage with and without HTTPS. The widths were checked, the heights weren't. JSON response was checked, XML wasn't.

comment:10 @wonderboymusic12 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

XML works, just checked.

comment:11 @iseulde11 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

According to #28507, CollegeHumor.com does not support SSL for its embeds. We should probably remove this until they do.

comment:12 @SergeyBiryukov11 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Per IRC discussion, let's deal with SSL issues in #28507.

Note: See TracTickets for help on using tickets.