WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#24519 closed task (blessed) (fixed)

Add Post Format icons to the old radio chooser

Reported by: markjaquith Owned by: helen
Milestone: 3.6 Priority: high
Severity: normal Version: 3.6
Component: Post Formats Keywords: has-patch
Focuses: Cc:

Description

Little post format icons should be added to the old radio chooser, like MelChoyce mocked up:

http://f.cl.ly/items/3Y0k1b2j1n3k3g2k1545/post-formats-metabox-2.png

Attachments (2)

24519.patch (4.0 KB) - added by ryelle 2 years ago.
24519.2.patch (4.6 KB) - added by kovshenin 2 years ago.

Download all attachments as: .zip

Change History (8)

@ryelle2 years ago

comment:1 @ryelle2 years ago

Added spans using the classes from the post list table icons, so I also had to remove the element from the selectors in CSS & add a format-standard class. I also added more space around the options.

comment:2 @helen2 years ago

Would it make more sense to change the sprites to be vertical and nix the empty span? I'd also rather add a selector or name it better rather than shoe-horning in one that isn't very semantic to use.

comment:3 @DrewAPicture2 years ago

  • Keywords needs-refresh added

@kovshenin2 years ago

comment:4 @kovshenin2 years ago

  • Keywords has-patch added; needs-refresh removed

Refreshed in 24519.2.patch

comment:5 @helen2 years ago

In 24426:

Change the post format icons sprite to be vertical rather than horizontal in order to allow it to be used for wider items such as labels. RTL tweak for the icon in the posts list table. See #16047, #24519.

comment:6 @helen2 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 24429:

Add post format icons to the radio chooser. This also trims empty margins from the sprites to make them usable in RTL and make positioning numbers more sane. props ryelle, kovshenin for the initial patch. fixes #24519.

Note: See TracTickets for help on using tickets.