WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#24520 closed defect (bug) (fixed)

TinyMCE - Edit Link - New Window bug

Reported by: sc0ttkclark's profile sc0ttkclark Owned by: markjaquith's profile markjaquith
Milestone: 3.6 Priority: normal
Severity: minor Version: 3.5.1
Component: TinyMCE Keywords: has-patch
Focuses: Cc:

Description

The value of inputes.openInNewTab is set to true only if the target is _blank, but if it isn't, it isn't unchecked.

Steps to reproduce:

  1. Add two links, make the first one not open in new window, make the second open in new window
  1. Be sure to edit the link that opens in a new window, so the checkbox will be set to checked, close the edit prompt
  1. Now edit the link that doesn't open in a new window, the checkbox remains checked and hasn't been turned off

I'm attaching a proposed patch for the resolution.

Attachments (3)

24520.patch​ (18.7 KB) - added by sc0ttkclark 11 years ago.
Fixes the minor JS true/false check
24520.2.patch​ (18.6 KB) - added by sc0ttkclark 11 years ago.
Fixed patch to base at /trunk/
24520.3.patch​ (705 bytes) - added by sc0ttkclark 11 years ago.
Remove min file from patch

Download all attachments as: .zip

Change History (6)

@sc0ttkclark
11 years ago

Fixes the minor JS true/false check

#1 @sc0ttkclark
11 years ago

  • Keywords has-patch added

@sc0ttkclark
11 years ago

Fixed patch to base at /trunk/

@sc0ttkclark
11 years ago

Remove min file from patch

#2 @markjaquith
11 years ago

  • Milestone changed from Awaiting Review to 3.6
  • Owner set to markjaquith
  • Status changed from new to accepted

#3 @markjaquith
11 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 24419:

Properly uncheck the "new tab" box when editing a non-new-tab link.

Previously, if you had just edited a new-tab link, a subsequent edit of a non-new-tab link would mistakenly keep the checkbox checked.

props sc0ttkclark. fixes #24520.

Note: See TracTickets for help on using tickets.