WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#24522 closed defect (bug) (fixed)

Remove the cite element from comment_html5()

Reported by: ocean90 Owned by: ocean90
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Comments Keywords: has-patch
Focuses: Cc:

Description

http://wordpress.org/support/topic/comment-author-markup-in-html5-cite-is-correct

In HTML5 the <cite> element shouldn't be used, when referring to a name/author.

Sources:

The Release Candidate proposes the <b> element, which sounds fair enough. obenland mentioned, that it would also set itself apart from the sorrounding <span>.

Attachments (2)

24522.patch (758 bytes) - added by ocean90 8 years ago.
24522.twentythirteen.patch (463 bytes) - added by ocean90 8 years ago.

Download all attachments as: .zip

Change History (9)

@ocean90
8 years ago

#2 @obenland
8 years ago

Right, I also think <b> is a bit less generic than <span>.

#3 @ocean90
8 years ago

  • Summary changed from Remove the cite element from comment_html5 to Remove the cite element from comment_html5()

#4 follow-up: @lancewillett
8 years ago

+1 to this change. A brief look at Twenty Thirteen, no changes needed as we don't style that particular element with a cite in any selectors.

#5 in reply to: ↑ 4 @ocean90
8 years ago

Replying to lancewillett:

+1 to this change. A brief look at Twenty Thirteen, no changes needed as we don't style that particular element with a cite in any selectors.

A side effect will be, that the font will be bold, which can be fixed by adding font-weight: normal to .comment-author .fn.

#6 @lancewillett
8 years ago

In 24535:

Twenty Thirteen: ensure b element in comment markup isn't bold. Props ocean90, see #24522.

#7 @ocean90
8 years ago

  • Owner set to ocean90
  • Resolution set to fixed
  • Status changed from new to closed

In 24539:

Replace the cite element with a b element to markup the comment author in comment_html5().

In HTML5 the cite element isn't valid for just an author's name.
"The cite element represents the title of a work .. A person's name is not the title of a work" (http://www.w3.org/TR/html5/text-level-semantics.html#the-cite-element)

fixed #24522.

Note: See TracTickets for help on using tickets.