Opened 12 years ago
Closed 12 years ago
#24538 closed defect (bug) (wontfix)
Twenty Thirteen: Instagram embeds are forced to thumbnail size because of 604 `content_width` value
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | |
| Component: | Bundled Theme | Keywords: | has-patch |
| Focuses: | Cc: |
Description
When you embed an Instagram URL in a post, the size comes back as 304 pixels wide, their "thumbnail" size.
http://instagram.com/developer/embedding/ shows the sizes.
Would be nice to filter or change the embed call for Twenty Thirteen so that we can get at least 604 to fit the main content width.
Attachments (1)
Change History (10)
#2
@
12 years ago
As I mentioned in IRC, it kinda sucks that the difference between thumbnail and medium size is so big and we're only 8px away from getting the bigger image.
In the interest of keeping the theme code simple, I'd lean towards leaving as is though. Maybe this is something that can be addressed in core?
#3
@
12 years ago
Maybe this is something that can be addressed in core?
Strike that. Probably more in a plugin. :)
#4
@
12 years ago
- Keywords has-patch added
24538.diff sets the minimum width for the Instagram oembed endpoint.
#5
follow-up:
↓ 6
@
12 years ago
0 !== strpos() in 24538.diff might be confusing, as we usually compare strpos() fo false.
#6
in reply to:
↑ 5
@
12 years ago
Replying to SergeyBiryukov:
True, although in this case we're not only looking for the substring occurrence, but also making sure it's at the very beginning (at position 0).
#7
follow-up:
↓ 9
@
12 years ago
-1. The only way this should be fixed in Twenty Thirteen is by bumping the content width globally to 612. This is not something I want to see proliferate into other themes.
(In general, modifying the $content_width is a bad idea because it doesn't work "on the fly" — it changes how data is stored in the database. Which is why I have objected to #21256.)
#8
@
12 years ago
The fix should probably go into an Instagram or embed plugin, it was pointed out on WP.com that users can use a shortcode already to work around this:
[instagram url=http://instagram.com/p/LFcgLXwyNA/ width=604]
#9
in reply to:
↑ 7
@
12 years ago
- Milestone 3.6 deleted
- Resolution set to wontfix
- Status changed from new to closed
Replying to nacin:
-1. The only way this should be fixed in Twenty Thirteen is by bumping the content width globally to 612. This is not something I want to see proliferate into other themes.[...]
Replying to lancewillett:
The fix should probably go into an Instagram or embed plugin[...]
Agreed, let's close this.
Originally reported on WordPress.com: http://en.forums.wordpress.com/topic/using-instagram-images-with-twenty-thirteen-theme?replies=2#post-1296342