WordPress.org

Make WordPress Core

#24538 closed defect (bug) (wontfix)

Twenty Thirteen: Instagram embeds are forced to thumbnail size because of 604 `content_width` value

Reported by: lancewillett Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

When you embed an Instagram URL in a post, the size comes back as 304 pixels wide, their "thumbnail" size.

http://instagram.com/developer/embedding/ shows the sizes.

Would be nice to filter or change the embed call for Twenty Thirteen so that we can get at least 604 to fit the main content width.

Attachments (1)

24538.diff (970 bytes) - added by kovshenin 10 months ago.

Download all attachments as: .zip

Change History (10)

comment:2 obenland11 months ago

As I mentioned in IRC, it kinda sucks that the difference between thumbnail and medium size is so big and we're only 8px away from getting the bigger image.

In the interest of keeping the theme code simple, I'd lean towards leaving as is though. Maybe this is something that can be addressed in core?

comment:3 obenland11 months ago

Maybe this is something that can be addressed in core?

Strike that. Probably more in a plugin. :)

kovshenin10 months ago

comment:4 kovshenin10 months ago

  • Keywords has-patch added

24538.diff sets the minimum width for the Instagram oembed endpoint.

comment:5 follow-up: SergeyBiryukov10 months ago

0 !== strpos() in 24538.diff might be confusing, as we usually compare strpos() fo false.

comment:6 in reply to: ↑ 5 kovshenin10 months ago

Replying to SergeyBiryukov:
True, although in this case we're not only looking for the substring occurrence, but also making sure it's at the very beginning (at position 0).

comment:7 follow-up: nacin10 months ago

-1. The only way this should be fixed in Twenty Thirteen is by bumping the content width globally to 612. This is not something I want to see proliferate into other themes.

(In general, modifying the $content_width is a bad idea because it doesn't work "on the fly" — it changes how data is stored in the database. Which is why I have objected to #21256.)

comment:8 lancewillett10 months ago

The fix should probably go into an Instagram or embed plugin, it was pointed out on WP.com that users can use a shortcode already to work around this:

[instagram url=http://instagram.com/p/LFcgLXwyNA/ width=604]

comment:9 in reply to: ↑ 7 obenland10 months ago

  • Milestone 3.6 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Replying to nacin:

-1. The only way this should be fixed in Twenty Thirteen is by bumping the content width globally to 612. This is not something I want to see proliferate into other themes.[...]

Replying to lancewillett:

The fix should probably go into an Instagram or embed plugin[...]

Agreed, let's close this.

Note: See TracTickets for help on using tickets.