Twenty Thirteen: Respect post password settings in image attachments?

[obenland]

In case the image attachment's parent post is password protected, we probably shouldn't display the image. Does someone have a better idea than to ask for the parent's post password?

Downside:
Since images can now be part of multiple galleries, it might happen that certain images in a gallery require a password because it has a different parent post (that is password protected), while others do not.

Thoughts?

[lancewillett]

Seems like that should be handled in core, not the theme.

[obenland]

It would be handled in get_the_content(), if we let core display the image.

[lancewillett]

I'm leaning toward punting on this one, maybe to 3.7. The post is protected, not the media elements uploaded, necessarily.

[obenland]

Let's discuss this in 3.7 a bit more.

[lancewillett]

After discussing again today in bug scrub (​log) I think we have several things to decide:

1. Should this be pushed to a core solution, regardless of themes? Where authors can choose a more fine-grained approach to protecting media items regardless of which post they are a) attached to and b) displayed with?
2. Should we just go ahead and patch the default themes with a check for password protection in the image templates?

In my mind it's a minor edge case so doesn't need immediate attention, but we should loop back to it soon.

[lancewillett]

Anyone up for making this a core patch rather than theme-specific? Open up a new Trac ticket and close this one.

[obenland]

I still feel like it's a valid ticket but it doesn't look like there are a lot of people bitten by it. Let's close it for now.