WordPress.org

Make WordPress Core

Opened 21 months ago

Last modified 12 months ago

#24542 new defect (bug)

Twenty Thirteen: Respect post password settings in image attachments?

Reported by: obenland Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: close
Focuses: Cc:

Description

In case the image attachment's parent post is password protected, we probably shouldn't display the image. Does someone have a better idea than to ask for the parent's post password?

Downside:
Since images can now be part of multiple galleries, it might happen that certain images in a gallery require a password because it has a different parent post (that is password protected), while others do not.

Thoughts?

Attachments (1)

24542.diff (2.6 KB) - added by obenland 21 months ago.

Download all attachments as: .zip

Change History (10)

@obenland21 months ago

comment:1 @lancewillett21 months ago

Seems like that should be handled in core, not the theme.

comment:2 @obenland21 months ago

It would be handled in get_the_content(), if we let core display the image.

comment:3 @obenland21 months ago

  • Keywords dev-feedback added

comment:4 @lancewillett20 months ago

I'm leaning toward punting on this one, maybe to 3.7. The post is protected, not the media elements uploaded, necessarily.

comment:5 @lancewillett20 months ago

  • Milestone changed from 3.6 to Future Release

comment:6 @obenland19 months ago

  • Milestone changed from Future Release to 3.7

Let's discuss this in 3.7 a bit more.

comment:7 @tollmanz19 months ago

  • Cc tollmanz@… added

comment:8 @lancewillett18 months ago

  • Milestone changed from 3.7 to Future Release

After discussing again today in bug scrub (log) I think we have several things to decide:

  1. Should this be pushed to a core solution, regardless of themes? Where authors can choose a more fine-grained approach to protecting media items regardless of which post they are a) attached to and b) displayed with?
  2. Should we just go ahead and patch the default themes with a check for password protection in the image templates?

In my mind it's a minor edge case so doesn't need immediate attention, but we should loop back to it soon.

comment:9 @lancewillett12 months ago

  • Keywords close added; has-patch dev-feedback removed

Anyone up for making this a core patch rather than theme-specific? Open up a new Trac ticket and close this one.

Note: See TracTickets for help on using tickets.