WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 11 days ago

#24542 closed defect (bug) (maybelater)

Twenty Thirteen: Respect post password settings in image attachments?

Reported by: obenland Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: close
Focuses: Cc:

Description

In case the image attachment's parent post is password protected, we probably shouldn't display the image. Does someone have a better idea than to ask for the parent's post password?

Downside:
Since images can now be part of multiple galleries, it might happen that certain images in a gallery require a password because it has a different parent post (that is password protected), while others do not.

Thoughts?

Attachments (1)

24542.diff (2.6 KB) - added by obenland 2 years ago.

Download all attachments as: .zip

Change History (11)

@obenland2 years ago

comment:1 @lancewillett2 years ago

Seems like that should be handled in core, not the theme.

comment:2 @obenland2 years ago

It would be handled in get_the_content(), if we let core display the image.

comment:3 @obenland2 years ago

  • Keywords dev-feedback added

comment:4 @lancewillett2 years ago

I'm leaning toward punting on this one, maybe to 3.7. The post is protected, not the media elements uploaded, necessarily.

comment:5 @lancewillett2 years ago

  • Milestone changed from 3.6 to Future Release

comment:6 @obenland2 years ago

  • Milestone changed from Future Release to 3.7

Let's discuss this in 3.7 a bit more.

comment:7 @tollmanz2 years ago

  • Cc tollmanz@… added

comment:8 @lancewillett2 years ago

  • Milestone changed from 3.7 to Future Release

After discussing again today in bug scrub (log) I think we have several things to decide:

  1. Should this be pushed to a core solution, regardless of themes? Where authors can choose a more fine-grained approach to protecting media items regardless of which post they are a) attached to and b) displayed with?
  2. Should we just go ahead and patch the default themes with a check for password protection in the image templates?

In my mind it's a minor edge case so doesn't need immediate attention, but we should loop back to it soon.

comment:9 @lancewillett18 months ago

  • Keywords close added; has-patch dev-feedback removed

Anyone up for making this a core patch rather than theme-specific? Open up a new Trac ticket and close this one.

comment:10 @obenland11 days ago

  • Milestone Future Release deleted
  • Resolution set to maybelater
  • Status changed from new to closed

I still feel like it's a valid ticket but it doesn't look like there are a lot of people bitten by it. Let's close it for now.

Note: See TracTickets for help on using tickets.