#24546 closed defect (bug) (fixed)
String issue in Menu page
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 3.6 | Priority: | normal |
| Severity: | normal | Version: | 3.6 |
| Component: | I18N | Keywords: | has-patch |
| Focuses: | Cc: |
Description
While test the FR translation for 3.6, I noticed two issues in the Appearance > Menus page:
- In the Help tab, the "Menus can be displayed..." sentence is followed immediately by the "If your theme does not support..." sentence. In order to have a space between them, the first sentence adds a final space that is not too obvious to translators, thus potentially resulting in a paragraphe where the full stop of the first sentence has the next sentence first letter stuck to it. I think the whole paragraph should be just one string.
- The "Auto add pages" setting does give much space: translated to proper, full-word French, it gives a string that overlaps the checkbox and its label (see capture). I can use shorter words, but some languages might not have this luxury.
Attachments (6)
Change History (15)
#1
@
13 years ago
- Component changed from General to I18N
- Milestone changed from Awaiting Review to 3.6
#2
follow-up:
↓ 4
@
13 years ago
- Keywords has-patch added; needs-patch removed
24546.patch widens the left padding on the checkbox input to 200px.
I thought about mimicking the markup produced by the Settings API (tables), but this solution basically lets us keep the look we wanted while allowing just as much space as you get with any other Settings screen.
#4
in reply to:
↑ 2
@
13 years ago
Replying to DrewAPicture:
24546.patch widens the left padding on the checkbox input to 200px.
200px still isn't enough for Russian, see 24546.after.png.
I guess we can just move <dd> to its own line: 24546.2.patch, 24546.2.after.png.
#5
follow-up:
↓ 6
@
13 years ago
I guess my question is how do we overcome this problem for other settings screens if 200px width isn't enough? Does it just wrap?
24546.2.after.png is a reasonable solution, I'm just looking for consistency in how this looks vs the settings tables. If it does wrap, I'd be more inclined to wrap it here, rather than drop the dd to its own line.
#6
in reply to:
↑ 5
@
13 years ago
Replying to DrewAPicture:
I guess my question is how do we overcome this problem for other settings screens if 200px width isn't enough? Does it just wrap?
It does. Other settings screens are tables, so we don't have to do anything special there: 24546.reading-settings.png.
String overlap.