Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#24547 closed defect (bug) (fixed)

"Go to All %s" string not ready for i18n

Reported by: xibe's profile xibe Owned by: azaozz's profile azaozz
Milestone: 3.6 Priority: high
Severity: major Version: 3.6
Component: I18N Keywords: 2nd-opinion
Focuses: Cc:


The "Go to All %s" string (location is marked with %s being any post type: "Posts, Pages, etc.".

As it is, translators cannot do a direct translation of it: as with any "any post type"-related string, it should be known that depending on the language, some post types can have a "gender", and therefore cannot use the same sentence structure.

For instance, in French, Post is Article, which is masculine, when Page is Page, which is feminine. Translation for this string would then either be "Aller à tous les articles" or "Aller à toutes les pages".

Either the string is reworked, or translators should be advised to use a sentence structure that works for any content type.

Attachments (2)

locked.png (12.8 KB) - added by azaozz 11 years ago.
24547.patch (867 bytes) - added by azaozz 11 years ago.

Download all attachments as: .zip

Change History (7)

#1 @nacin
11 years ago

  • Milestone changed from Awaiting Review to 3.6
  • Priority changed from normal to high
  • Severity changed from normal to major

#2 @azaozz
11 years ago

One way to fix this would be to drop the "Go to" part and use get_post_type_object( $post->post_type )->labels->all_items;. The button will have exactly the same action and label as the menu.

11 years ago

#3 @azaozz
11 years ago

Alternatively can more the "Go to" part before the button where "Go" can be "Navigate" or "Move", etc.

In the plugin attached to #18515 the same button is called GET ME OUT :)

Other ideas/suggestions?

Last edited 11 years ago by azaozz (previous) (diff)

11 years ago

#4 @SergeyBiryukov
11 years ago

Introduced in [24408].

Yes, we should avoid post type and taxonomy names in generic strings, as noted in ticket:17609:3 and ticket:19099:1.

24547.patch looks good to me.

#5 @azaozz
11 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 24527:

Post locked dialog: remove the "Go to" part from the button as it's not translatable. Fixes #24547.

Note: See TracTickets for help on using tickets.