WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#24555 closed defect (bug) (fixed)

Twenty Thirteen: First image in featured gallery can be blurry if in landscape

Reported by: obenland Owned by: lancewillett
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Reported in IRC, if a landscape oriented image happens to be the first image in a featured gallery, it appears blurry. Since the medium image size does not crop, the image is most likely not 300px high. This causes the image to be magnified and to appear blurry.

We previously discussed the issue of the best image size to use in IRC, I couldn't find the log in a reasonable amount of time though.

Attachments (6)

fuzzy-first-image.png (1.2 MB) - added by obenland 8 years ago.
24555.diff (1.9 KB) - added by obenland 8 years ago.
24555.2.diff (3.9 KB) - added by lancewillett 8 years ago.
24555.3.diff (744 bytes) - added by rdall 8 years ago.
24555.4.diff (7.5 KB) - added by lancewillett 8 years ago.
Another pass, includes removing mobile and RTL styles
24555.5.diff (7.7 KB) - added by lancewillett 8 years ago.
Minor fix to selector, props obenland

Download all attachments as: .zip

Change History (29)

#1 @ziegenberg
8 years ago

  • Cc daniel@… added

#2 in reply to: ↑ description @knutsp
8 years ago

Replying to obenland:

We previously discussed the issue of the best image size to use in IRC, I couldn't find the log in a reasonable amount of time though.

This? https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2013-05-23&sort=asc#m616985

#24307 seems related

#3 @obenland
8 years ago

  • Keywords dev-feedback added

#4 @lancewillett
8 years ago

I think we can detect "landscape" class value from core for the gallery image, and change the size to make sure it's not blurry.

#5 @lancewillett
8 years ago

  • Keywords needs-patch added; dev-feedback removed

#6 @lancewillett
8 years ago

I tried a lot of variations on layout changes to account for landscape images being 200 or so in height, at "medium" default media cropped size.

Nothing works well. :/

I'd like to consider -- bringing up to core leadership team -- re-instating the custom image size of 300x300. I think it's worth the extra file storage and overhead to make these galleries look great with good quality images.

#7 @lancewillett
8 years ago

After considering this a lot more, and weighing our options (a customized layout versus the overhead it requires) we've decided to simplify things. Going with a thumbnail grid, without a larger first image. Basically styling index and single exactly the same, for galleries.

This means removing twentythirteen_gallery_atts() and the CSS that changes the index layout for gallery post formats.

See also #23649 #23823 and #24307. Lots of IRC discussion, also, most recently here.

#8 @lancewillett
8 years ago

@obenland is going to work on a patch to get this ready.

@obenland
8 years ago

#9 @obenland
8 years ago

  • Keywords has-patch added; needs-patch removed

#10 @lancewillett
8 years ago

Patch is a good start, but I think as I mentioned I think index and single should look the same. Centered, thumbs.

#11 @lancewillett
8 years ago

  • Keywords needs-refresh needs-patch added; has-patch removed

@lancewillett
8 years ago

#12 follow-up: @lancewillett
8 years ago

  • Keywords has-patch added; needs-refresh needs-patch removed

.2 removes more special styles for blog/search/index and ensures similar view for single view. I don't think we need the 1, 2, and 3 column max-width rules.

#13 in reply to: ↑ 12 ; follow-up: @obenland
8 years ago

Replying to lancewillett:

.2 removes more special styles for blog/search/index and ensures similar view for single view.

I'm not sure I understand why index and single should look the same. They don't currently.


I don't think we need the 1, 2, and 3 column max-width rules.

We have to constrain them in width so galleries work with image sizes bigger than thumbnails.

#14 @nacin
8 years ago

I <3 all of the red in 24555.2.diff.

#15 in reply to: ↑ 13 ; follow-up: @lancewillett
8 years ago

Replying to obenland:

Replying to lancewillett:

.2 removes more special styles for blog/search/index and ensures similar view for single view.

I'm not sure I understand why index and single should look the same. They don't currently.

They don't currently and that's a bug in my opinion. Since we're showing a thumbnail grid now (not the big first image as before) they should look the same on both views.

Why would you want them to look different?

#16 @rdall
8 years ago

  • Cc robert@… added

#17 @rdall
8 years ago

When the page is resized the images are shown differently on the home page then they are when it is resized on the single page. See Screenshot that is has both. Left is the front page right is the single post page. I agree with lance it is still a bug.

http://cl.ly/image/1f3O0H3T2n3w

#18 @nacin
8 years ago

I'm +100 on 24555.2.diff.

N.B. If anything, it'd be the single view that should have a bigger photo.

@rdall
8 years ago

#19 @rdall
8 years ago

I removed the

.gallery-item:first-child 

which seems to be causing the layout problem I mentioned above. As this if my first submitted patch I hope I submitted that properly… 

#20 in reply to: ↑ 15 ; follow-up: @obenland
8 years ago

Replying to lancewillett:

They don't currently and that's a bug in my opinion. Since we're showing a thumbnail grid now (not the big first image as before) they should look the same on both views.

Why would you want them to look different?

It would be a standardized look for all galleries on index, no matter the individual settings. I just thought the bigger first image was maybe not the only reason to have them different in the first place.

But I can get behind having them look the same on both single and index.

#21 in reply to: ↑ 20 @lancewillett
8 years ago

Replying to obenland:

But I can get behind having them look the same on both single and index.

:) -- let's do it and get this ticket closed. Want to test my patch? .2

#22 @rdall
8 years ago

Seem I applied only patch2 instead of both patches… Disregard my patch… 

@lancewillett
8 years ago

Another pass, includes removing mobile and RTL styles

@lancewillett
8 years ago

Minor fix to selector, props obenland

#23 @lancewillett
8 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24720:

Twenty Thirteen: improve gallery styles to ensure both single and index views are displayed consistently. Closes #24555.

Note: See TracTickets for help on using tickets.