WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#24610 closed task (blessed) (fixed)

Do something with the_post_format_*() functions

Reported by: markjaquith Owned by: markjaquith
Milestone: 3.6 Priority: high
Severity: blocker Version: 3.6
Component: Post Formats Keywords: has-patch commit
Focuses: Cc:

Description (last modified by wonderboymusic)

As a remaining bit of the post format UI extraction, we need a strategy for functions like:

  • the_post_format_video()
  • the_post_format_audio()
  • the_post_format_image()

And some of their get counterparts.

Attachments (1)

24610.diff (6.3 KB) - added by wonderboymusic 7 years ago.

Download all attachments as: .zip

Change History (14)

#1 @wonderboymusic
7 years ago

  • Description modified (diff)

#2 @wonderboymusic
7 years ago

I am going to suggest moving these functions into the plugin and not leaving them in core

@wonderboymusic
7 years ago

#3 @wonderboymusic
7 years ago

  • Keywords has-patch commit added

Pour one out 24610.diff​

#4 @DrewAPicture
7 years ago

  • Cc xoodrew@… added

#5 @jupiterwise
7 years ago

  • Cc corey.mckrill@… added

#6 @johnzanussi
7 years ago

  • Cc johnzanussi@… added

#7 @aaroncampbell
7 years ago

  • Cc aaroncampbell added

#8 @ocean90
7 years ago

+1 for removing.

#9 @markjaquith
7 years ago

  • Severity changed from normal to blocker

#10 @markjaquith
7 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 24555:

Remove some more post format functions.

props wonderboymusic. fixes #24610.

#11 @ocean90
7 years ago

img_html_to_post_id() should be removed as well.

#12 @SergeyBiryukov
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#13 @ocean90
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 24569:

Remove img_html_to_post_id(). It's unused since [24555]. fixes #24610.

Note: See TracTickets for help on using tickets.