Context Navigation

← Previous Ticket
Next Ticket →

#24618 closed defect (bug) (fixed)

Enhancement for validate_username

Reported by:	gwinh.lopez	Owned by:	chriscct7
Priority:	normal	Milestone:	4.4
Component:	Users	Version:
Severity:	normal	Keywords:	has-patch commit
Cc:		Focuses:

Description

the validate_username returns true on an empty string which obviously is not a valid username.

Attachments (4)

enhance.vun.diff (466 bytes ) - added by gwinh.lopez 13 years ago.
24618.patch (472 bytes ) - added by mordauk 12 years ago.
24618-tests.patch (780 bytes ) - added by mordauk 12 years ago.: Unit tests for validate_username()
24618.2.patch (1.2 KB ) - added by chriscct7 11 years ago.

Download all attachments as: .zip

Change History (13)

@gwinh.lopez
13 years ago

Attachment enhance.vun.diff added

#1 @SergeyBiryukov
13 years ago

Component Validation → Users
Keywords has-patch added; needs-patch removed

#2 @mordauk
12 years ago

I've just confirmed the bug.

@mordauk
12 years ago

Attachment 24618.patch added

#3 @mordauk
12 years ago

Keywords good-first-bug added

24618.patch is a refreshed patch with proper formatting.

I'm going to write up another patch shortly that adds unit tests for this as well.

#4 @mordauk
12 years ago

Type enhancement → defect (bug)

@mordauk
12 years ago

Attachment 24618-tests.patch added

Unit tests for validate_username()

#5 @mordauk
12 years ago

Keywords good-first-bug removed

24618-tests.patch adds some basic unit tests for validate_username(). I'm sure there are more assertions we could make, but this is better than none at all.