WordPress.org

Make WordPress Core

#24627 closed defect (bug) (fixed)

Fatal error in wp-admin/setup-config.php

Reported by: SergeyBiryukov Owned by: nacin
Milestone: 3.6 Priority: high
Severity: blocker Version: 3.6
Component: Upgrade/Install Keywords: has-patch
Focuses: Cc:

Description

There's a fatal error in wp-admin/setup-config.php when creating wp-config.php via the web interface.

Introduced in [24480] and [24482]. [24497] added a function_exists() check for wp_kses_bad_protocol(), since it's not available in setup-config.php. However, as noted by markoheijnen in IRC, wp_http_validate_url() calls esc_url(), which in turn calls wp_kses_bad_protocol() too, so wp_http_validate_url() should also be wrapped in the function_exists() check.

In 3.5.2 reject_unsafe_urls is false by default, so wp_http_validate_url() is not called, and there's no error.
Even if a mu-plugin changes reject_unsafe_urls to true, plugins are not loaded in setup-config.php.

Attachments (1)

24627.patch (643 bytes) - added by SergeyBiryukov 10 months ago.

Download all attachments as: .zip

Change History (2)

SergeyBiryukov10 months ago

comment:1 nacin10 months ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24503:

Broader fix for [24497] for setup-config.php in trunk. props SergeyBiryukov, markoheijnen. fixes #24627.

Note: See TracTickets for help on using tickets.