WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#24628 closed defect (bug) (wontfix)

Twenty Thirteen: Redundant code in style.css

Reported by: gorgoglionemeister Owned by:
Milestone: Priority: low
Severity: normal Version: 3.6
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

The pattern

.navbar {
	margin: 0 auto;
	max-width: 1600px;
	width: 100%;
}

applied to navbar is unnecessary because it's already applied to navbar's ancestor, site. It can be removed.

Attachments (1)

24628.diff (462 bytes) - added by gorgoglionemeister 2 years ago.

Download all attachments as: .zip

Change History (5)

@gorgoglionemeister2 years ago

comment:1 follow-up: @lancewillett2 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 3.6
  • Priority changed from normal to low

Related to #24406

comment:2 in reply to: ↑ 1 @gorgoglionemeister2 years ago

Replying to lancewillett:

Related to #24406

In #24406 we consider the case where .site can be as large as body, but the designer decision is that it can be at maximum 1600 pixel width, so is there a reason to change this?

comment:3 @lancewillett2 years ago

Needs testing. ;)

comment:4 @lancewillett2 years ago

  • Keywords needs-testing removed
  • Milestone 3.6 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Discussed in IRC during Twenty Thirteen office hours today, and decided it's so minor that it's not worth a fix.

Note: See TracTickets for help on using tickets.