Changes between Initial Version and Version 1 of Ticket #24633, comment 84
- Timestamp:
- 02/02/2015 04:28:32 PM (10 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #24633, comment 84
initial v1 4 4 Namespacing it sounds good. However moving it to wp-util.js doesn't seem right. Currently user-profile.js requires password-strength-meter.js which loads zxcvbn.min.js which is a 683KB minified JS file. There is no way we are going to load that "globally" :) 5 5 6 Perhaps better to add the password checking/generating functions to `wp.passwordStrength` in password-strength-meter.js? Then we can enqueue that file everywhere a password can be typed. I know the names aren't that good. We could probably rename the file, but should keep the script-loader "handle" name for back-com mpat.6 Perhaps better to add the password checking/generating functions to `wp.passwordStrength` in password-strength-meter.js? Then we can enqueue that file everywhere a password can be typed. I know the names aren't that good. We could probably rename the file, but should keep the script-loader "handle" name for back-compat.