Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 4 years ago

#24643 closed defect (bug) (fixed)

Twenty Thirteen: Minor js cleanup

Reported by: obenland's profile obenland Owned by: lancewillett's profile lancewillett
Milestone: 3.6 Priority: low
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

I noticed some unused and overused variables in our main js file. With the removal of fixed navbar code from functions.js in r24169, it gives us the chance to optimize it further.

Attachments (1)

24643.patch (1.9 KB) - added by obenland 11 years ago.

Download all attachments as: .zip

Change History (6)

@obenland
11 years ago

#1 @obenland
11 years ago

  • Priority changed from normal to low

#2 @lancewillett
11 years ago

JS changes look good.

However, you missed bumping the JS version in wp_enqueue_script() call. I'll bump it in the commit.

#3 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24511:

Twenty Thirteen: functions.js optimizations, props obenland. Fixes #24643.

#4 @lancewillett
11 years ago

In 24514:

Twenty Thirteen: JS fix, after r24511 changes -- add missing semicolon to end variable definition. See #24643.

This ticket was mentioned in Slack in #core by andraganescu. View the logs.


4 years ago

Note: See TracTickets for help on using tickets.