WordPress.org

Make WordPress Core

Opened 10 months ago

Closed 10 months ago

Last modified 10 months ago

#24643 closed defect (bug) (fixed)

Twenty Thirteen: Minor js cleanup

Reported by: obenland Owned by: lancewillett
Milestone: 3.6 Priority: low
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

I noticed some unused and overused variables in our main js file. With the removal of fixed navbar code from functions.js in r24169, it gives us the chance to optimize it further.

Attachments (1)

24643.patch (1.9 KB) - added by obenland 10 months ago.

Download all attachments as: .zip

Change History (5)

obenland10 months ago

comment:1 obenland10 months ago

  • Priority changed from normal to low

comment:2 lancewillett10 months ago

JS changes look good.

However, you missed bumping the JS version in wp_enqueue_script() call. I'll bump it in the commit.

comment:3 lancewillett10 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24511:

Twenty Thirteen: functions.js optimizations, props obenland. Fixes #24643.

comment:4 lancewillett10 months ago

In 24514:

Twenty Thirteen: JS fix, after r24511 changes -- add missing semicolon to end variable definition. See #24643.

Note: See TracTickets for help on using tickets.