WordPress.org

Make WordPress Core

Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#24643 closed defect (bug) (fixed)

Twenty Thirteen: Minor js cleanup

Reported by: obenland Owned by: lancewillett
Milestone: 3.6 Priority: low
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

I noticed some unused and overused variables in our main js file. With the removal of fixed navbar code from functions.js in r24169, it gives us the chance to optimize it further.

Attachments (1)

24643.patch (1.9 KB) - added by obenland 20 months ago.

Download all attachments as: .zip

Change History (5)

@obenland20 months ago

comment:1 @obenland20 months ago

  • Priority changed from normal to low

comment:2 @lancewillett20 months ago

JS changes look good.

However, you missed bumping the JS version in wp_enqueue_script() call. I'll bump it in the commit.

comment:3 @lancewillett20 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24511:

Twenty Thirteen: functions.js optimizations, props obenland. Fixes #24643.

comment:4 @lancewillett20 months ago

In 24514:

Twenty Thirteen: JS fix, after r24511 changes -- add missing semicolon to end variable definition. See #24643.

Note: See TracTickets for help on using tickets.