Opened 11 years ago
Closed 11 years ago
#24651 closed enhancement (fixed)
Twenty Thirteen: some stylesheet cleanup
Reported by: | gorgoglionemeister | Owned by: | lancewillett |
---|---|---|---|
Milestone: | 3.6 | Priority: | low |
Severity: | normal | Version: | 3.6 |
Component: | Bundled Theme | Keywords: | needs-refresh has-patch |
Focuses: | Cc: |
Description
In style.css:
line 863: rgba(247, 245, 231, 1)
is the same as #f7f5e7
(am I wrong?), so we should use the second notation.
line 865: color: #fff;
can be removed because it is defined below (line 884) and does nothing.
line 867: float: left;
has no effect since we are using position: absolute;
and must be removed.
line 871: top: 45px;
is not necessary since it is the used value for top
(every li
element is 45 pixels high).
Attachments (1)
Change History (7)
#2
in reply to:
↑ 1
@
11 years ago
Replying to alexvorn2:
I think rgba(247, 245, 231, 1) is better because of opacity.
rgba(247, 245, 231, 1)
is the same as rgb(247, 245, 231)
and, according to the CSS Coding Standards, we must use the hex instead of the functional notation for colors.
#3
follow-up:
↓ 4
@
11 years ago
- Keywords needs-refresh has-patch added
- Milestone changed from Awaiting Review to 3.6
- Priority changed from normal to low
- Type changed from defect (bug) to enhancement
- Version set to trunk
It indeed looks like the styles can be safely removed. Still need to make IE tests, but if it breaks there (which I doubt), these styles would belong in /css/ie.css
anyway.
gorgoglionemeister, could you refresh your patch and make the path relative to WordPress' root?
#4
in reply to:
↑ 3
@
11 years ago
Replying to obenland:
It indeed looks like the styles can be safely removed. Still need to make IE tests, but if it breaks there (which I doubt), these styles would belong in
/css/ie.css
anyway.
gorgoglionemeister, could you refresh your patch and make the path relative to WordPress' root?
Yes, sure. Sorry.
I think rgba(247, 245, 231, 1) is better because of opacity.