WordPress.org

Make WordPress Core

#24651 closed enhancement (fixed)

Twenty Thirteen: some stylesheet cleanup

Reported by: gorgoglionemeister Owned by: lancewillett
Milestone: 3.6 Priority: low
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: needs-refresh has-patch
Focuses: Cc:

Description

In style.css:

line 863: rgba(247, 245, 231, 1) is the same as #f7f5e7 (am I wrong?), so we should use the second notation.

line 865: color: #fff; can be removed because it is defined below (line 884) and does nothing.

line 867: float: left; has no effect since we are using position: absolute; and must be removed.

line 871: top: 45px; is not necessary since it is the used value for top (every li element is 45 pixels high).

Attachments (1)

24651.diff (563 bytes) - added by gorgoglionemeister 10 months ago.

Download all attachments as: .zip

Change History (7)

comment:1 follow-up: alexvorn210 months ago

I think rgba(247, 245, 231, 1) is better because of opacity.

comment:2 in reply to: ↑ 1 gorgoglionemeister10 months ago

Replying to alexvorn2:

I think rgba(247, 245, 231, 1) is better because of opacity.

rgba(247, 245, 231, 1) is the same as rgb(247, 245, 231) and, according to the CSS Coding Standards, we must use the hex instead of the functional notation for colors.

comment:3 follow-up: obenland10 months ago

  • Keywords needs-refresh has-patch added
  • Milestone changed from Awaiting Review to 3.6
  • Priority changed from normal to low
  • Type changed from defect (bug) to enhancement
  • Version set to trunk

It indeed looks like the styles can be safely removed. Still need to make IE tests, but if it breaks there (which I doubt), these styles would belong in /css/ie.css anyway.

gorgoglionemeister, could you refresh your patch and make the path relative to WordPress' root?

comment:4 in reply to: ↑ 3 gorgoglionemeister10 months ago

Replying to obenland:

It indeed looks like the styles can be safely removed. Still need to make IE tests, but if it breaks there (which I doubt), these styles would belong in /css/ie.css anyway.

gorgoglionemeister, could you refresh your patch and make the path relative to WordPress' root?

Yes, sure. Sorry.

gorgoglionemeister10 months ago

comment:5 lancewillett10 months ago

Yes, the changes do break things in IE8 and 7, the dropdown is off by a few pixels. But we can remove the following from the ie.css file:

.nav-menu .sub-menu,
.nav-menu .children {
	left: 0;
}

comment:6 lancewillett10 months ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 24542:

Twenty Thirteen: minor CSS cleanup for navigation, props gorgoglionemeister. Closes #24651.

Note: See TracTickets for help on using tickets.