Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#24653 closed enhancement (fixed)

Twenty Thirteen: Cleanup functions.php

Reported by: obenland Owned by:
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:


Based on Nacin's feedback, there are a few things that can be cleaned up:

  • Missing period in sidebar description.
  • Redundant conditional tags in twentythirteen_paging_nav().
  • Further simplify twentythirteen_the_attached_image().
  • Use add_editor_style() instead of adding a 'mce_css' callback (Requires a change to add_editor_style() where it accepts full URLs and escapes commas in those URLs).

Attachments (1)

24653.diff (3.3 KB) - added by obenland 5 years ago.

Download all attachments as: .zip

Change History (4)

5 years ago

#1 @obenland
5 years ago

Patch addresses:

  • Adds missing period in sidebar description.
  • Removes redundant conditional tags in twentythirteen_paging_nav().
  • Further simplifies twentythirteen_the_attached_image().
  • Removes braces from require statements (not a function).

#2 @lancewillett
5 years ago

In 24537:

Twenty Thirteen: cleanup for functions.php file, props obenland. See #24653.

#3 @lancewillett
5 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.