WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#24676 closed defect (bug) (fixed)

Twenty Thirteen: Status format selector adjustment

Reported by: celloexpressions Owned by: nacin
Milestone: 3.6 Priority: normal
Severity: minor Version: 3.6
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

When testing the editor styles, I noticed that the .format-status p:first-child:before selector also styles blockquotes (because wordpress adds <p> tags inside blockquotes). It doesn't seem like this is the intended design, since first-child is used (and people shouldn't use blockquotes here anyway), but perhaps .post-format-status > p:first-child:before was the intention? That would result in only the single occurrence, instead of the potential for multiple if there is a blockquote for some reason. It would also prevent the styling from displaying if the entire status is in a blockquote, though.

Current:
http://celloexpressions.com/files/status-format-blockqoute-0.png
Proposed:
http://celloexpressions.com/files/status-format-blockqoute-1.png
(by the way, the differing widths are an editor style bug).

Attachments (1)

24676.patch (919 bytes) - added by celloexpressions 6 years ago.
Add direct child selector

Download all attachments as: .zip

Change History (4)

@celloexpressions
6 years ago

Add direct child selector

#1 @lancewillett
6 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.6

#2 @obenland
6 years ago

  • Keywords commit added

+1

#3 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24657:

Twenty Thirteen: Use the child selector when styling paragraphs in a status post. props celloexpressions, fixes #24676.

Note: See TracTickets for help on using tickets.