#24682 closed enhancement (fixed)
Add 'Cancel' button to Revisions screen
Reported by: | DrewAPicture | Owned by: | nacin |
---|---|---|---|
Milestone: | 3.9 | Priority: | normal |
Severity: | normal | Version: | 3.6 |
Component: | Revisions | Keywords: | has-patch dev-feedback |
Focuses: | ui | Cc: |
Description (last modified by )
On the revisions screen(s) currently, the only way to get back to the post-editing screen is to click the link at the top in the middle of: 'Compare Revisions of "<linked>Post Title</linked>"', which seems neither intuitive nor obvious to me.
There was also a post awhile back in Alpha/Beta about this.
It would be nice if there were some user tests backing this up, but at this point in the cycle informed UX feedback should suffice.
The attached patch adds a secondary 'Cancel' button alongside the primary 'Restore This Revision' button. Also covers RTL.
Attachments (6)
Change History (39)
#3
@
11 years ago
+1 to the cancel button, I agree its confusing to only have the post title as the link back to the post edit screen. In addition, the latest revisions version features browser history tracking, so the browser back button no longer works as a shortcut back to the post edit screen.
We did have a cancel button in there at some point (see http://cl.ly/N3Kz/diffview.png), but in IRC it was discussed and decided to remove it.
#4
@
11 years ago
Revisions isn't just for restoring. It is also for reviewing and noting changes, and potentially resurrecting pieces of a post. Even if "Restore" is the only *action* that can be formally taken, "Cancel" isn't necessarily the right way to go back.
Something that allows for the user to go back is good. I just don't think it needs to be "Cancel". Perhaps there is another existing paradigm in core we can use.
#6
@
11 years ago
24682.2.patch uses the add-new-h2
style for 'Go Back'. First run retains the linked post title:
#7
@
11 years ago
If you also want to see a version with only 'Go Back' linked, see 24682-one-linked.patch: http://f.cl.ly/items/0y3R062P1Q2F443V080j/Screen%20Shot%202013-07-04%20at%201.20.09%20AM.png
#8
@
11 years ago
I like the location — it's most in-context. Pretty sure I like the "Go Back" text. Having something more specific is going to be a translation nightmare. And I think the post title should remain linked.
#9
@
11 years ago
#11
@
11 years ago
I'm not a fan of using the "Add New" UI element as an utility for a "Back" functionality. But otherwise I haven't a better idea for this. Maybe just add a title to the post link?
#12
@
11 years ago
i like the go back link, much more obvious for the end user. keep the post title linked as well;
#13
@
11 years ago
- Milestone changed from 3.6 to Future Release
But otherwise I haven't a better idea for this.
Yeah, it's kind of an odd situation. Considering that this isn't a new issue (it existed with the old UI), let's think about it some more.
#15
follow-up:
↓ 19
@
11 years ago
I was very confused by this situation today so it's good to see a ticket open about. Here's what happened:
- opened a post and it said that there was a more recent autosave
- clicked the autosave button and played around with the revisions.
- Clicked the "compare any two revisions" button, looked at a bunch of those
- finally decided that I didn't want to restore a revision as there was nothing relevant in the autosave. Since there was no obvious back button I clicked the browser back button in the browser but it goes through all of the revisions and takes ages to get back. It was very annoying as there was no simple way for me to get back to my post. I'd gone down the revisions rabbit hole but there was no quick way to leave without restoring a version.
Also, and this may be an edge case, when I'm editing writers' work on a multi-author blog I use revisions functionality so that they can review the changes that I've made. I do the same when someone else has edited my work. In this case there wouldn't be a situation in which you would click "Restore this Revision" as it's used only as a reference.
Drew's button make's sense, though I would change the text to "Go Back to Post". This makes it more specific while remaining translatable. "Go Back" could mean back to anything, including the post edit screen or dashboard, since they are also "back".
#17
@
11 years ago
- Milestone changed from Future Release to 3.7
Moving to 3.7 for discussion. We could also look at adding a button for the per-post comments context at the same.
#19
in reply to:
↑ 15
@
11 years ago
you can click on the post title (you did have a title, right?) to go back to the post edit screen at any time, although thats _clearly_ not obvious. I like 'Go Back to Post' or maybe just 'Back to Post'.
Replying to siobhan:
I was very confused by this situation today so it's good to see a ticket open about. Here's what happened:
- opened a post and it said that there was a more recent autosave
- clicked the autosave button and played around with the revisions.
- Clicked the "compare any two revisions" button, looked at a bunch of those
- finally decided that I didn't want to restore a revision as there was nothing relevant in the autosave. Since there was no obvious back button I clicked the browser back button in the browser but it goes through all of the revisions and takes ages to get back. It was very annoying as there was no simple way for me to get back to my post. I'd gone down the revisions rabbit hole but there was no quick way to leave without restoring a version.
Also, and this may be an edge case, when I'm editing writers' work on a multi-author blog I use revisions functionality so that they can review the changes that I've made. I do the same when someone else has edited my work. In this case there wouldn't be a situation in which you would click "Restore this Revision" as it's used only as a reference.
Drew's button make's sense, though I would change the text to "Go Back to Post". This makes it more specific while remaining translatable. "Go Back" could mean back to anything, including the post edit screen or dashboard, since they are also "back".
#21
@
11 years ago
- Milestone changed from 3.7 to Future Release
No consensus, already existed, punting time. I guess we'll keep thinking on it some more.
#24
follow-up:
↓ 27
@
10 years ago
- Keywords needs-patch added; has-patch removed
- Milestone changed from Future Release to 3.9
#26689's approach sounds good.
#25
@
10 years ago
- Keywords has-patch dev-feedback added; needs-patch removed
24682.diff uses the approach suggested in #26889 and looks like this:
(check out that spiffy dashicon)
just realized need to address RTL, adding that now
#26
@
10 years ago
24682.2.diff uses right arrow for 'Return to post editor' link when in RTL mode, looks like this:
#27
in reply to:
↑ 24
@
10 years ago
Replying to nacin:
#26689's approach sounds good.
I believe you meant #26889: attempting that in 24682.2.diff
#28
@
10 years ago
We actually already use ← within a link when editing a user. It's a bit weird, but it seems less weird than the dashicon.
#29
@
10 years ago
- Owner set to nacin
- Resolution set to fixed
- Status changed from new to closed
In 27383:
#30
follow-up:
↓ 32
@
10 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Replying to nacin:
In 27383:
← looks fine to me, however I noticed that in RTL mode, the arrow is pointing the wrong way - forward (== left in rtl) instead of back (right in rtl).
Here is a screen shot:
24682.3.diff corrects this, and the return links looks like this:
Before the patch:
After the patch: