WordPress.org

Make WordPress Core

Opened 10 months ago

Closed 6 weeks ago

Last modified 6 weeks ago

#24682 closed enhancement (fixed)

Add 'Cancel' button to Revisions screen

Reported by: DrewAPicture Owned by: nacin
Milestone: 3.9 Priority: normal
Severity: normal Version: 3.6
Component: Revisions Keywords: has-patch dev-feedback
Focuses: ui Cc:

Description (last modified by DrewAPicture)

On the revisions screen(s) currently, the only way to get back to the post-editing screen is to click the link at the top in the middle of: 'Compare Revisions of "<linked>Post Title</linked>"', which seems neither intuitive nor obvious to me.

There was also a post awhile back in Alpha/Beta about this.

It would be nice if there were some user tests backing this up, but at this point in the cycle informed UX feedback should suffice.

The attached patch adds a secondary 'Cancel' button alongside the primary 'Restore This Revision' button. Also covers RTL.

Related: #23497, #24425

Attachments (6)

24682.patch (1.4 KB) - added by DrewAPicture 10 months ago.
24682.2.patch (526 bytes) - added by DrewAPicture 10 months ago.
24682-one-linked.patch (625 bytes) - added by DrewAPicture 10 months ago.
alternative: only link 'Go Back'
24682.diff (1.0 KB) - added by adamsilverstein 3 months ago.
add return to post editor link below compare revisions title
24682.2.diff (1.0 KB) - added by adamsilverstein 3 months ago.
use right arrow for rtl mode
24682.3.diff (743 bytes) - added by adamsilverstein 6 weeks ago.
use &rarr; for rtl mode

Download all attachments as: .zip

Change History (39)

DrewAPicture10 months ago

comment:1 DrewAPicture10 months ago

Before the patch:
http://f.cl.ly/items/3q2z2l1k02410R0I1W1j/Screen%20Shot%202013-07-03%20at%208.11.49%20PM.png

After the patch:
http://f.cl.ly/items/0n2N2v1p2Q3G0o3X1r3S/Screen%20Shot%202013-07-03%20at%208.09.43%20PM.png

comment:2 DrewAPicture10 months ago

  • Description modified (diff)

comment:3 adamsilverstein10 months ago

+1 to the cancel button, I agree its confusing to only have the post title as the link back to the post edit screen. In addition, the latest revisions version features browser history tracking, so the browser back button no longer works as a shortcut back to the post edit screen.

We did have a cancel button in there at some point (see http://cl.ly/N3Kz/diffview.png), but in IRC it was discussed and decided to remove it.

comment:4 nacin10 months ago

Revisions isn't just for restoring. It is also for reviewing and noting changes, and potentially resurrecting pieces of a post. Even if "Restore" is the only *action* that can be formally taken, "Cancel" isn't necessarily the right way to go back.

Something that allows for the user to go back is good. I just don't think it needs to be "Cancel". Perhaps there is another existing paradigm in core we can use.

comment:5 markjaquith10 months ago

It's less "cancel" and more "back".

comment:6 DrewAPicture10 months ago

24682.2.patch uses the add-new-h2 style for 'Go Back'. First run retains the linked post title:

http://f.cl.ly/items/1m2z452L2q161Q0d0K2p/Screen%20Shot%202013-07-04%20at%201.14.56%20AM.png

DrewAPicture10 months ago

DrewAPicture10 months ago

alternative: only link 'Go Back'

comment:8 markjaquith10 months ago

I like the location — it's most in-context. Pretty sure I like the "Go Back" text. Having something more specific is going to be a translation nightmare. And I think the post title should remain linked.

comment:9 SergeyBiryukov10 months ago

FWIW, the Comments screen for a particular post (edit-comments.php?p=123) also only has the link in the post title as a way to go back (added in [16619]). Related: #21010.

Version 0, edited 10 months ago by SergeyBiryukov (next)

comment:10 DrewAPicture10 months ago

  • Milestone changed from Awaiting Review to 3.6

comment:11 ocean9010 months ago

I'm not a fan of using the "Add New" UI element as an utility for a "Back" functionality. But otherwise I haven't a better idea for this. Maybe just add a title to the post link?

comment:12 adamsilverstein10 months ago

i like the go back link, much more obvious for the end user. keep the post title linked as well;

comment:13 markjaquith10 months ago

  • Milestone changed from 3.6 to Future Release

But otherwise I haven't a better idea for this.

Yeah, it's kind of an odd situation. Considering that this isn't a new issue (it existed with the old UI), let's think about it some more.

comment:14 ocean909 months ago

#24918 was marked as a duplicate.

comment:15 follow-up: siobhan8 months ago

I was very confused by this situation today so it's good to see a ticket open about. Here's what happened:

  • opened a post and it said that there was a more recent autosave
  • clicked the autosave button and played around with the revisions.
  • Clicked the "compare any two revisions" button, looked at a bunch of those
  • finally decided that I didn't want to restore a revision as there was nothing relevant in the autosave. Since there was no obvious back button I clicked the browser back button in the browser but it goes through all of the revisions and takes ages to get back. It was very annoying as there was no simple way for me to get back to my post. I'd gone down the revisions rabbit hole but there was no quick way to leave without restoring a version.

Also, and this may be an edge case, when I'm editing writers' work on a multi-author blog I use revisions functionality so that they can review the changes that I've made. I do the same when someone else has edited my work. In this case there wouldn't be a situation in which you would click "Restore this Revision" as it's used only as a reference.

Drew's button make's sense, though I would change the text to "Go Back to Post". This makes it more specific while remaining translatable. "Go Back" could mean back to anything, including the post edit screen or dashboard, since they are also "back".

comment:16 siobhan8 months ago

  • Cc siobhan added

comment:17 DrewAPicture8 months ago

  • Milestone changed from Future Release to 3.7

Moving to 3.7 for discussion. We could also look at adding a button for the per-post comments context at the same.

comment:18 Hanni8 months ago

  • Cc h@… added

comment:19 in reply to: ↑ 15 adamsilverstein8 months ago

you can click on the post title (you did have a title, right?) to go back to the post edit screen at any time, although thats _clearly_ not obvious. I like 'Go Back to Post' or maybe just 'Back to Post'.

Replying to siobhan:

I was very confused by this situation today so it's good to see a ticket open about. Here's what happened:

  • opened a post and it said that there was a more recent autosave
  • clicked the autosave button and played around with the revisions.
  • Clicked the "compare any two revisions" button, looked at a bunch of those
  • finally decided that I didn't want to restore a revision as there was nothing relevant in the autosave. Since there was no obvious back button I clicked the browser back button in the browser but it goes through all of the revisions and takes ages to get back. It was very annoying as there was no simple way for me to get back to my post. I'd gone down the revisions rabbit hole but there was no quick way to leave without restoring a version.

Also, and this may be an edge case, when I'm editing writers' work on a multi-author blog I use revisions functionality so that they can review the changes that I've made. I do the same when someone else has edited my work. In this case there wouldn't be a situation in which you would click "Restore this Revision" as it's used only as a reference.

Drew's button make's sense, though I would change the text to "Go Back to Post". This makes it more specific while remaining translatable. "Go Back" could mean back to anything, including the post edit screen or dashboard, since they are also "back".

comment:20 desrosj8 months ago

  • Cc desrosj@… added

comment:21 helen7 months ago

  • Milestone changed from 3.7 to Future Release

No consensus, already existed, punting time. I guess we'll keep thinking on it some more.

comment:22 ocean903 months ago

#26889 was marked as a duplicate.

comment:23 ocean903 months ago

  • Focuses ui added
  • Keywords ux-feedback removed

comment:24 follow-up: nacin3 months ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from Future Release to 3.9

#26689's approach sounds good.

adamsilverstein3 months ago

add return to post editor link below compare revisions title

comment:25 adamsilverstein3 months ago

  • Keywords has-patch dev-feedback added; needs-patch removed

24682.diff uses the approach suggested in #26889 and looks like this:
https://i.cloudup.com/pLjZDloBbM.jpg
(check out that spiffy dashicon)

just realized need to address RTL, adding that now

Last edited 3 months ago by adamsilverstein (previous) (diff)

adamsilverstein3 months ago

use right arrow for rtl mode

comment:26 adamsilverstein3 months ago

24682.2.diff uses right arrow for 'Return to post editor' link when in RTL mode, looks like this:

http://f.cl.ly/items/0L093O3l3p220b2J1f11/%D7%92%D7%A8%D7%A1%D7%90%D7%95%D7%AA%20%E2%80%BA%20WordPress%20Development%20Test%20Environment%20%E2%80%94%20%D7%95%D7%95%D7%A8%D7%93%D7%A4%D7%A8%D7%A1%202014-01-28%2010-11-56.jpg

comment:27 in reply to: ↑ 24 adamsilverstein3 months ago

Replying to nacin:

#26689's approach sounds good.

I believe you meant #26889: attempting that in 24682.2.diff

comment:28 nacin7 weeks ago

We actually already use &larr; within a link when editing a user. It's a bit weird, but it seems less weird than the dashicon.

comment:29 nacin7 weeks ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27383:

Revisions: Add 'Return to post editor' link.

props adamsilverstein, jenmylo.
fixes #24682.

adamsilverstein6 weeks ago

use &rarr; for rtl mode

comment:30 follow-up: adamsilverstein6 weeks ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to nacin:

In 27383:

Revisions: Add 'Return to post editor' link.

props adamsilverstein, jenmylo.
fixes #24682.

&larr; looks fine to me, however I noticed that in RTL mode, the arrow is pointing the wrong way - forward (== left in rtl) instead of back (right in rtl).

Here is a screen shot:

http://f.cl.ly/items/1g1c1n1D0B3g3p0I0p3O/%D7%92%D7%A8%D7%A1%D7%90%D7%95%D7%AA%20%E2%80%BA%20WordPress%20Development%20Test%20Environment%20%E2%80%94%20%D7%95%D7%95%D7%A8%D7%93%D7%A4%D7%A8%D7%A1%202014-03-06%2007-23-56%202014-03-06%2007-23-58.jpg

24682.3.diff corrects this, and the return links looks like this:

http://f.cl.ly/items/3U0u2D2u2I3G46182o29/%D7%92%D7%A8%D7%A1%D7%90%D7%95%D7%AA%20%E2%80%BA%20WordPress%20Development%20Test%20Environment%20%E2%80%94%20%D7%95%D7%95%D7%A8%D7%93%D7%A4%D7%A8%D7%A1%202014-03-06%2007-35-16%202014-03-06%2007-35-32.jpg

comment:31 ircbot6 weeks ago

This ticket was mentioned in IRC in #wordpress-dev by adamsilverstein. View the logs.

comment:32 in reply to: ↑ 30 ; follow-up: ocean906 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to adamsilverstein:

&larr; looks fine to me, however I noticed that in RTL mode, the arrow is pointing the wrong way

RTL translators will translate this correct.

comment:33 in reply to: ↑ 32 adamsilverstein6 weeks ago

Replying to ocean90:

Replying to adamsilverstein:

&larr; looks fine to me, however I noticed that in RTL mode, the arrow is pointing the wrong way

RTL translators will translate this correct.

ok, makes sense, thanks!

Note: See TracTickets for help on using tickets.