WordPress.org

Make WordPress Core

Opened 10 months ago

Closed 9 months ago

Last modified 9 months ago

#24683 closed enhancement (wontfix)

Twenty Thirteen: basic tweaks for a better stylesheet readibility

Reported by: gorgoglionemeister Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

Continuing in my exploration of Twenty Thirteen:

I removed a property that should be placed in ie.css;

I grouped related inherited properties (color, font-family and line-height) all in one place. I chose the "html" element but "body" works as well (feedback about that is well accepted).

Furthermore, about links, as far as I know

a:visited {
	color: #ac0404;
}

is never applied to any elements. It can be safely removed.

In the navigation section, instead, at line 851, text-decoration: none is already set to a.

Attachments (1)

24683.diff (1.3 KB) - added by gorgoglionemeister 10 months ago.

Download all attachments as: .zip

Change History (6)

gorgoglionemeister10 months ago

comment:1 follow-ups: SergeyBiryukov10 months ago

Furthermore, about links, as far as I know

a:visited {
	color: #ac0404;
}

is never applied to any elements. It can be safely removed.

Related: http://stackoverflow.com/a/5222282.

comment:2 in reply to: ↑ 1 gorgoglionemeister10 months ago

Replying to SergeyBiryukov:

Furthermore, about links, as far as I know

a:visited {
	color: #ac0404;
}

is never applied to any elements. It can be safely removed.

Related: http://stackoverflow.com/a/5222282.

Unlike what is asserted in the link, today the "visited" style is present (tested in Firefox 22 and Chrome 28).

Despite the security issue (which I didn't know), that rule can be removed because is always overridden by other rules in the stylesheet and never applied.

comment:3 lancewillett9 months ago

  • Keywords close added

I'd vote to "wontfix" all these changes.

comment:4 obenland9 months ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

+1

comment:5 in reply to: ↑ 1 rmccue9 months ago

Replying to SergeyBiryukov:

Related: http://stackoverflow.com/a/5222282.

The styles are still applied, but any calculations use the non-visited version.

Note: See TracTickets for help on using tickets.