WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 6 weeks ago

#24689 reviewing enhancement

Improve error wp-admin page

Reported by: alexvorn2 Owned by: chriscct7
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch needs-refresh has-ux-feedback
Focuses: Cc:

Description

"You do not have sufficient permissions to access this page." this is the only content on the error page, It would be nice to have a link to a Dashboard page if the user is logged.

Maybe we can integrate this error message into a wp-admin dashboard.

Attachments (2)

24689.patch (1008 bytes) - added by drayne 4 years ago.
24689.2.diff (492 bytes) - added by Shelob9 2 years ago.
More useful message when admin page doesn't exist

Download all attachments as: .zip

Change History (15)

@drayne
4 years ago

#2 @drayne
4 years ago

  • Cc drayne added
  • Keywords has-patch added

I added a patch which will show a navigational button to the error page shown when wp_die is called. It first checks to see if wp_die is called with a parameter to show a button which triggers javascript back. If not, it will show a button which takes the user either to the dashboard or to the Wordpress home depending on whether the user is logged in or not.

Basically, this error page should not result in a dead end. It needs navigation.

#4 @chriscct7
2 years ago

  • Owner set to chriscct7
  • Status changed from new to reviewing

#5 @swissspidy
2 years ago

  • Keywords needs-refresh added

I like the idea. I'd use home_url() / site_url() here though, as / and /wp-admin/ aren't correct for sub folder installs.

#6 @karmatosed
2 years ago

  • Keywords ux-feedback added

#7 @Shelob9
2 years ago

Also need to disambiguate between lack of permissions and lack of admin page, since You do not have sufficient permissions to access this page will show when accessing any page that doesn't exist and no capability -- besides the capability to make that page exists -- would be sufficient.

Last edited 2 years ago by Shelob9 (previous) (diff)

@Shelob9
2 years ago

More useful message when admin page doesn't exist

#8 @karmatosed
16 months ago

We seem to maybe have 2 patches for different things on this ticket - I may also be wrong in that assumption.

@Shelob9 looks like you are iterating on the message and @drayne looks like you are adding a button?

I would suggest we maybe combine them rather than having 2 things like this. I also would suggest a link over a button for this message. Could we maybe have a screenshot also to make the ticket easy to view for everyone?

#9 @Shelob9
16 months ago

@karmatosed -

If my memory is right, I opened this ticket after spending a lot of time trying to fix a permissions issue that wasn't a real permissions issue. I had created a link to an admin page that didn't exist, but WordPress was wp_die()ing at me about lack of permissions.

For example go to https://example.com/wp-admin/admin.php?page=shawn-hooper the error will tell you that the error is you don't have permission to access page. That's very wrong.

I probably should have opened a new ticket and gladly will if that is more likely lead to getting this minor issue. It's a separate issue from the larger issues of wp_die() in admin being a bad user experience, which it is, but I'm not the right person to be fixing.

My point is that in this one situation, the current system is not implimented properly.

#10 follow-up: @karmatosed
16 months ago

@Shelob9 I think either a new ticket to fix the existing and then this one being about the new approach, potentially makes sense. I would however also be keen to see the combination, but it would take someone combining.

#11 in reply to: ↑ 10 @SergeyBiryukov
11 months ago

Replying to karmatosed:

@Shelob9 I think either a new ticket to fix the existing and then this one being about the new approach, potentially makes sense.

No need for a new ticket, we can use #14060 to improve the existing message.

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


6 weeks ago

#13 @karmatosed
6 weeks ago

  • Keywords has-ux-feedback added; ux-feedback removed
Note: See TracTickets for help on using tickets.