get_template_part : !empty instead of isset ?

[tivnet]

With a call like this one:

get_template_part( 'content', get_post_format() );

get_post_format() may return false, and then the following condition does not do what it should:

	if ( isset($name) )
		$templates[] = "{$slug}-{$name}.php";

and tries to load content-.php
Using !empty instead of isset should work better.

[nacin]

Could probably just be if ( $name ), as we know the variable is set.

[nacin]

Actually, '0' is probably valid. Think get_template_part( 'something', get_query_var( 'paged' ) ) where an integer might be valid. Pagination generally starts with 1, but you get the idea.

False and null, cast to strings, equals ''. That's what is happening anyway (as in, if you pass an array, we'll go looking for "something-Array.php"), so let's be explicit and add a check.

[nacin]

In 24616:

In general template functions, cast to string then ensure we actually have a template name before proceeding. Affects get_sidebar(), get_header(), get_footer(), get_template_part().

props tivnet for initial patch.
fixes #24714.

[tivnet]

Replying to nacin:

In get_footer(), is that correct?

$name = (string) $name;
	if ( null !== $name && false !== $name )

[nacin]

In 24617:

Have get_footer() match get_header() etc in [24616]. fixes #24714.

[nacin]

Thanks tivnet. That was me experimenting with some alternative logic, and it snuck in.