Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #24716, comment 40


Ignore:
Timestamp:
06/29/2014 03:50:25 AM (10 years ago)
Author:
ericlewis
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24716, comment 40

    initial v1  
    88* Introduce `media.controller._State`, which is a more abstracted state controller object. `media.controller.State` is hard-wired to the regions defined by `media.view.MediaFrame`, while the only region we need in `media.view.Frame.EditMediaDetails` is `content`.
    99* `media.controller.EditImageNoFrame` is the state for editing an image (i.e. the cropping interface), a simplified version of `media.controller.EditImage` without the `toolbar` region setup, which we will not need.
    10 * Something I'm happy with: in `media.view.Attachment`, trigger an event on the frame controller `edit:attachment`, instead of creating the modal from within the view, the controller does on an event callback. We should continue to decouple components via the event API as much as possible.
     10* Something I'm happy with: in `media.view.Attachment`, trigger an `edit:attachment` event on the frame controller. Instead of creating the modal from within the `Attachment` view, the controller does so on an `edit:attachment` event callback. We should continue to decouple components via the events bus as much as possible.