Unused code in WP_Widgets::update_callback()

[jdgrimes]

The single argument for WP_Widgets::update_callback() ($widget_args) does not appear to have any usage in the function, except for the five references shown below, which alone don't seem to do anything.

if ( is_numeric($widget_args) )
       $widget_args = array( 'number' => $widget_args );
	
       $widget_args = wp_parse_args( $widget_args, array( 'number' => -1 ) );

[ocean90]

Hello jdgrimes, thanks for the report.

Yes, the code seems to be unused since it was introduced in [10798]. How bad.

[SergeyBiryukov]

The original code was introduced in [10764]. $widget_args was used in control_callback().

In [10798], control_callback() was renamed to update_callback(), and $widget_args usage was moved to form_callback().

So, yeah, unused since [10798].

[SergeyBiryukov]

In 27224:

Remove unused code from WP_Widget::update_callback().

props OriginalEXE.
fixes #24733.