WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#24739 closed defect (bug) (fixed)

Revisions RTL mode - new issues

Reported by: adamsilverstein Owned by: markjaquith
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Revisions Keywords: has-patch
Focuses: Cc:

Description

i've noticed two issues with the latest revisions code when viewing revisions in RTL mode:

  • tooltips locations are reversed
  • switching to two handled mode with 'to' at initial revision ('from':empty) fails

Attachments (2)

24739.diff (1.8 KB) - added by markjaquith 2 years ago.
24739.2.diff (1.9 KB) - added by DrewAPicture 2 years ago.

Download all attachments as: .zip

Change History (6)

@markjaquith2 years ago

@DrewAPicture2 years ago

comment:1 @DrewAPicture2 years ago

24739.2.diff adds a fixe for the gravatar alignment in RTL.
Before:
http://f.cl.ly/items/0k301t140k2n452Q1g1E/Screen%20Shot%202013-07-12%20at%208.23.47%20PM.png

After:
http://f.cl.ly/items/2y3I2v2D0r411i0I391R/Screen%20Shot%202013-07-12%20at%208.24.52%20PM.png

comment:2 @markjaquith2 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 24698:

Revisions: RTL tooltip fixes. Plus a fix for switching to compare-two mode while looking at the first revision.

Also, a meta box avatar RTL alignment fix. props DrewAPicture.

Fixes #24739.

comment:3 @DrewAPicture2 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.6

comment:4 @adamsilverstein2 years ago

that seems to have fixed everything in my testing, fantastic!

Note: See TracTickets for help on using tickets.