WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#24743 closed defect (bug) (fixed)

Revisions: Don't show 'false' in a tooltip when gravatars are disabled

Reported by: ocean90's profile ocean90 Owned by: markjaquith's profile markjaquith
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.6
Component: Revisions Keywords: has-patch commit 2nd-opinion
Focuses: Cc:

Description


Attachments (2)

24743.patch​ (655 bytes) - added by ocean90 11 years ago.
24743.diff​ (2.3 KB) - added by nacin 11 years ago.

Download all attachments as: .zip

Change History (6)

@ocean90
11 years ago

#1 @ocean90
11 years ago

  • Keywords has-patch added; needs-patch removed

#2 @markjaquith
11 years ago

  • Keywords commit 2nd-opinion added

This is good to go. Can I get another sign-off on it?

@nacin
11 years ago

#3 @nacin
11 years ago

Looks good. Here's something to speed things up a bit, especially when the same author does repeated edits.

#4 @markjaquith
11 years ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 24708:

Improvements to output of revisions author data.

  • Do not output "false" if avatars are disabled. props ocean90.
  • Cache the author data separately to cut down on calls to get_the_author_meta() and get_avatar(). props nacin.

Fixes #24743.

Note: See TracTickets for help on using tickets.