Add filter to query in get_page_by_path function

[zbtirrell]

We would like to be able to filter the query that is executed in get_page_by_path() so that we can have pages be children of a custom post_type.

To do this currently, we have to add a filter to 'query' and look for this specific query. This approach is unfortunately, quite expensive.

I am attaching a single line diff file that applies a filter to this query called 'get_page_by_path_request'.

[zbtirrell]

patch file for the suggested change

[jeremyfelt]

Hi @zbtirrell, thanks for the request and patch.

What alternative queries do you visualize using through this filter? I don't think we would want to apply a filter directly to the query itself. It is worth discussing what else could be added to help achieve your goal.

[zbtirrell]

We are specifically interested in adding additional post types, so this is the part that we are most interested in having the filter change:

(post_type = '$post_type_sql' OR post_type = 'attachment')

Perhaps we could allow for $post_types to be an array that gets imploded to build this segment?

[SergeyBiryukov]

Replying to zbtirrell:

Perhaps we could allow for $post_types to be an array that gets imploded to build this segment?

This seems like the way to go here. Let's do it for both get_page_by_path() and get_page_by_title().

[zbtirrell]

make the get_page_by_path function support an array of post types

[zbtirrell]

I did not make a patch for get_page_by_title() because it does not suffer from the same difficulty. Since it simply does a query on title and post type, it does not consider the page's hierarchy/ancestry, so is not broken if a page has an parent that is not a page.

So, while extending that function to support an array would potentially be useful, it seems out of scope from this request.

Note: I tested the patch against trunk.

[nacin]

We could choose to only add 'attachment' if you're passing a scalar value. If you pass an array, then it's an explicit list and attachments are ignored. Thoughts?

[zbtirrell]

a 3rd version of this patch, only adds attachment when post type is scalar

[zbtirrell]

Replying to nacin:

We could choose to only add 'attachment' if you're passing a scalar value. If you pass an array, then it's an explicit list and attachments are ignored. Thoughts?

Seems like a great idea, updated patch has been uploaded.

[nacin]

We're going to want to make the same changes to get_page_by_title() too.

[zbtirrell]

this patch also adds post type array support to get_page_by_title

[zbtirrell]

The updated patch now contains a change to add post type array support to get_page_by_title() as requested.

[johnbillion]

In 27423:

Allow get_page_by_path() and get_page_by_title() to accept an array of post types. Fixes #24763. Props zbtirrell.

[sebastian.pisula]

I think that filter is great idea.

[Jabawack]

Any news about a filter?