WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 7 months ago

#24777 closed enhancement (fixed)

wp-login mobile viewport

Reported by: bobbravo2 Owned by: helen
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.6
Component: General Keywords: has-patch 3.7-early commit
Focuses: Cc:

Description

The wp-login.php page has incorrectly formatted viewport arguments. They should be CSV, not ; separated. In addition, it is impossible for plugins to override this setting, which is why I added the "login_page_viewport" filter to allow 3rd party plugins to specify their own viewport.

Attachments (3)

24777.patch (637 bytes) - added by bobbravo2 9 months ago.
24777.2.patch (637 bytes) - added by bobbravo2 9 months ago.
24777.3.patch (1.0 KB) - added by azaozz 7 months ago.

Download all attachments as: .zip

Change History (13)

bobbravo29 months ago

comment:1 bobbravo29 months ago

Updated the maximum zoom to 1.1: http://cl.circletr.ee/image/2Y3N0w0g3w3L
Allows for larger type for older audience without breaking the interface
Max Zoom:
http://f.cl.ly/items/2m3x12003C2600381a20/Screen%20Shot%202013-07-16%20at%2017.59.00%20.png
Min Zoom:
http://f.cl.ly/items/3U230k460W3F1s2n2g3p/Screen%20Shot%202013-07-16%20at%2017.59.51%20.png

bobbravo29 months ago

comment:2 bobbravo29 months ago

  • Version set to trunk

comment:3 nacin9 months ago

In 24779:

Use commas, not semicolons, to separate meta viewport values. props bobbravo2. see #24777.

comment:4 nacin9 months ago

  • Keywords 3.7-early added
  • Milestone changed from Awaiting Review to Future Release
  • Severity changed from major to normal
  • Type changed from defect (bug) to enhancement

Bug fixed for 3.6 in [24779], leaving the rest for a future release and further discussion.

comment:5 wonderboymusic9 months ago

  • Milestone changed from Future Release to 3.7

these are all marked 3.7-early

comment:6 bobbravo29 months ago

My general idea for this patch is to make the login page more accessible, and also allow plugin authors to override the login page viewport. I don't like to disable user scale, as that makes it harder for older people to use the login page, as they cannot zoom in if they have vision impairments.

comment:7 nacin7 months ago

So to be clear:

  • remove user-scalable=0
  • make maximum-scale=1.1

Rather than a filter, we would attach an action to login_head and output the meta tag there. But I'm not sure this is necessary for now with a change in the scale?

comment:8 azaozz7 months ago

Seems the least intrusive value for the meta is content="width=device-width" as the whole form is 320px wide. Tested on iPad and Android 4.3 phone. If we need to shrink it a bit so it doesn't have horizontal scroll on older phones (320px width), this can be done better in the css. Also agree with @bobbravo2, don't see a point in limiting the scaling, no need for maximum-scale.

Last edited 7 months ago by azaozz (previous) (diff)

azaozz7 months ago

comment:9 nacin7 months ago

  • Keywords commit added

Let's call it wp_login_viewport_meta() and you have yourselves a deal.

comment:10 helen7 months ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 25619:

Simplify the login page viewport meta for mobile devices, so it's less restrictive on the user. Allows for developers to override if necessary via the login_head action. props azaozz. fixes #24777.

Note: See TracTickets for help on using tickets.