Opened 12 years ago
Closed 12 years ago
#24789 closed defect (bug) (fixed)
Spellcheck API used by TinyMCE broken
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.6 | Priority: | high |
Severity: | major | Version: | |
Component: | TinyMCE | Keywords: | has-patch |
Focuses: | Cc: |
Description
It looks like google shut off the API TinyMCE used by default. http://www.tinymce.com/forum/viewtopic.php?id=30779
It looks like After the Deadline has an API, and Jetpack is already using it. Theres a TinyMCE plugin built already. Good option to get in core to resolve this? http://www.afterthedeadline.com/download.slp?platform=TinyMCE
Opening new to not clutter previous related ticket #23343
Attachments (2)
Change History (10)
#2
@
12 years ago
- Priority changed from normal to high
- Severity changed from normal to major
Previously the endpoint went down as a 50x. It is now a 404. Not just direct GET access, but the actual HTTP request WP normally does.
#3
@
12 years ago
Found a few other projects reporting similar. And the response, for the most part, was to just rip it out.
Don't most browsers support spell checking now as well? I know in at least Chrome and Safari on OSX I get spelling errors automatically highlighted. Not sure if that's a browser or host OS service though.
From a quick search it looks like IE doesn't have built in spell check capabilities (other than 3rd party plugin) so that could be a bigger hinderance to the "just disable" option.
#4
@
12 years ago
IE10 has a spell checker.
I see no need for core to include a spell checker. Let it be a plugin. I have always used a browser extension, as it also works outside of WordPress and includes Norwegian.
#5
@
12 years ago
At this point I think we're leaning toward taking it out. Or even just disabling the button, to avoid ripping out a lot so late in a cycle. Browsers cover this pretty well for us, even the good mobile ones.
#6
@
12 years ago
- Keywords has-patch added
Agreed there.
Adding patch that just removes it from the TinyMCE plugins array for now so the button doesn't load. The rest of the code around the spellchecker plugin was left intact.
#7
@
12 years ago
24789.2.diff expands on 24789.diff, also preventing the initialization of spellchecker settings if the plugin isn't enabled. (Most of that green is merely indentation.)
As stated in IRC, three options:
I don't think any of these are mutually exclusive.