WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 3 years ago

Last modified 3 years ago

#24802 closed defect (bug) (invalid)

Don't set slug explicitely to null in wp_update_nav_menu_object

Reported by: Chouby Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: has-patch needs-unit-tests
Focuses: Cc:

Description

This new ticket is related to #23199, #21950, #5809 (shared terms)

If a user creates a new nav menu with the same name as an existing term in another taxonomy, the term is shared with this other taxonomy. This is known and probably not an issue here.

But when the menu is saved, calling update_term with the slug explicitely set to null does modify the (shared) term slug.

Attachments (1)

24802.patch (611 bytes) - added by Chouby 5 years ago.

Download all attachments as: .zip

Change History (7)

@Chouby
5 years ago

#1 @Chouby
5 years ago

  • Keywords has-patch added

#2 @nacin
5 years ago

  • Keywords needs-unit-tests added

Makes sense at a glance. Unit tests would help make this happen.

#3 @nacin
5 years ago

  • Version changed from trunk to 3.0

#4 @Chouby
4 years ago

Obviously, this ticket should have been fixed by the resolution of #5809. I propose to close it.

#5 @Chouby
3 years ago

  • Resolution set to invalid
  • Status changed from new to closed

#6 @netweb
3 years ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.