wp_counts_posts produces a notice if a non existant post type is specified

[creativeinfusion]

Calling wp_count_posts with a non existant post type and perm='readable' produces a notice.

wp_count_posts ('doesnotexist', 'readable') will generate

Notice: Trying to get property of non-object in wp-includes/post.php

[johnpbloch]

Updated patch with feedback from Aaron Campbell

[johnpbloch]

Instead of checking the post type, it would make more sense for the function to simply return an empty object right away.

[nacin]

WP_Error might be better but this function has existed around too long, and it doesn't fail hard enough to justify a new return type.

[johnpbloch]

Yeah, the second patch returns WP_Error; if we want to do it that way, we can just use that patch. :D

[johnpbloch]

Except for the typo in the query. Fat fingers. 24803.3.diff is the patch, though. Unit tests are forthcoming.

[johnpbloch]

Unit test

[nacin]

In 24826:

Return an empty stdClass from wp_count_posts() when a nonexistent post type is requested.

props johnpbloch.
fixes #24803.

[SergeyBiryukov]

[1323/tests]