Non-rendered HTML entity in audio description in media manager

[tollmanz]

When viewing an audio file in the media manager modal window, the description prints non-rendered HTML entities in the description field. See attached image for example.

To Reproduce:

1. Grab Mr. Taylor's excellent sample MP3 with ID3 tags: ​http://core.trac.wordpress.org/attachment/ticket/24805/13%20Soul%20Calibur.mp3
2. In a post edit screen, click Add Media
3. Upload the MP3
4. Upon upload, notice the description:

   “Soul Calibur” from Nostalgia by Frank Ocean. Released: 2011. Track 13 of 14. Genre: R&B.
   

5. The entities are not converted when displayed in the textarea

For reference:

• In wp-admin/includes/media.php, the curly quotes are set on lines 237-247.
• In wp-includes/media.php:L1591 the content is prepared for JS. At that point the entities are not rendered.
• In wp-includes/media-template.php:L237, the description is printed to the screen as part of a JS template

I'm not really sure what the right move would be here. Convert entities in wp-includes/media.php? Unescape them on output (sounds horribly wrong?

Also, why are we using curly quotes here?

[tollmanz]

Example of non-rendered entities

[nacin]

Moving to 3.6 for review.

[nacin]

We should be using straight quotes here and then letting texturize curl them when rendering a description or general post content.

[tollmanz]

Ok. Sounds good! I'm happy to work on a patch for this as I've already done some of the leg work on the issue.

[nacin]

Replying to tollmanz:

Ok. Sounds good! I'm happy to work on a patch for this as I've already done some of the leg work on the issue.

Sorry — next time just patch if you can.

[nacin]

In [24788]:

Remove curly quotes from auto content generation for audio tracks on upload. Texturize should be doing this on display.

props tollmanz.
fixes #24810.