Post counts for 'mine' and 'all' can be inconsistent on edit posts admin screens

[creativeinfusion]

The count for the users own posts and the count for all posts should both use the same post status criteria, but at present 'all' posts excludes the show_in_admin_all_list statuses whilst the user count only excludes trash and draft.

An easy way to test this without needing to create custom statuses is

1. Log in to wp-admin without having edit_others_post capability (e.g. author)
2. Upload a media item if this user doesn't have any
3. Go to edit posts screen
4. Modify the query to include ?post_type=attachment

[creativeinfusion]

Add show_in_admin_all_list states into user counts query

[creativeinfusion]

Related #23501

[anonymized_10276468]

I am so sorry but where else did i change the keywords? I am sorry if i made a mistake but i'm still learning. I apologize

[helen]

Replying to anand.potukuchi:

I've seen you do this keyword changing without further explanation a few times - care to explain why?

[SergeyBiryukov]

The patch needs a refresh, it duplicates line 59. See also ​http://make.wordpress.org/core/handbook/coding-standards/php/#space-usage.

[SergeyBiryukov]

Replying to anand.potukuchi:

If you're just getting familiar with the Trac workflow, take a look at ​http://make.wordpress.org/core/handbook/trac/keywords/. If you have any questions, just ask in #wordpress-dev or #wordpress-contribute.

Note that submitting a patch makes you a core contributor (once the patch is committed), but not a Core Developer of WordPress (which is what your WP.org profile currently says), see ​http://make.wordpress.org/core/handbook/project-organization/.

[creativeinfusion]

Replying to SergeyBiryukov:

The patch needs a refresh, it duplicates line 59. See also ​http://make.wordpress.org/core/handbook/coding-standards/php/#space-usage.

Patch corrected and thanks for the coding pointers.

[SergeyBiryukov]

This would be consistent with [13198].

[anonymized_10276468]

Replying to SergeyBiryukov:

Replying to anand.potukuchi:

If you're just getting familiar with the Trac workflow, take a look at ​http://make.wordpress.org/core/handbook/trac/keywords/. If you have any questions, just ask in #wordpress-dev or #wordpress-contribute.

Note that submitting a patch makes you a core contributor (once the patch is committed), but not a Core Developer of WordPress (which is what your WP.org profile currently says), see ​http://make.wordpress.org/core/handbook/project-organization/.

I got that. changed to WP contributor. how do i get to #wordpress-dev/contribuite. I am new here. Sorry if i caused any misconceptions/problems.

[anonymized_10276468]

Replying to helen:

Replying to anand.potukuchi:

I've seen you do this keyword changing without further explanation a few times - care to explain why?

I am so sorry but where else did i change the keywords? I am sorry if i made a mistake but i'm still learning. I apologize

[wonderboymusic]

these are all marked 3.7-early

[nacin]

Looks good. I agree with Sergey.

Observation: It seems the original report uses attachments as an example because the only internal status other than trash and auto-draft is inherit.

[nacin]

In 25676:

Post lists table: When counting a user's posts, use get_post_stati() instead of hardcoded internal statuses.

props creativeinfusion.
fixes #24818.