Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#24820 closed defect (bug) (fixed)

Clean up wp_audio_shortcode() and wp_video_shortcode()

Reported by:	nacin	Owned by:	nacin
Priority:	low	Milestone:	3.6
Component:	Embeds	Version:	3.6
Severity:	minor	Keywords:
Cc:		Focuses:

Description

Some post format remnants in both of these functions.

Also, I think we should pass the content width to the wp-mediaelement.js script and specify it for the audioWidth option (width of the audio player).

Attachments (4)

media-shortcode-cleanup.diff (2.3 KB ) - added by rfair404 13 years ago.: replaces the format based classes with wp-media and wp-{type} classes
without-localizing.diff (1.6 KB ) - added by rfair404 13 years ago.: without localization
without-localizing2.diff (1.6 KB ) - added by rfair404 13 years ago.
24820.diff (1.2 KB ) - added by rfair404 13 years ago.: exclude the changes to wp-mediaelement.js

Download all attachments as: .zip

Change History (9)

#1 @nacin
13 years ago

Related bug: #24421.

@rfair404
13 years ago

Attachment media-shortcode-cleanup.diff added

replaces the format based classes with wp-media and wp-{type} classes

#2 @rfair404
13 years ago

Not sure if localizing the width is very useful without "doing something" with the width value, e.g. modifying the mediaelement.js.

@rfair404
13 years ago

Attachment without-localizing.diff added

without localization

@rfair404
13 years ago

Attachment without-localizing2.diff added

@rfair404
13 years ago

Attachment 24820.diff added

exclude the changes to wp-mediaelement.js

#3 @rfair404
13 years ago

Cc rfair404 added
Component General → Embeds

#4 @nacin
13 years ago

Owner set to nacin
Resolution → fixed
Status new → closed

Update HTML classes in the audio and video shortcodes. props rfair404. fixes #24820.

#5 @nacin
13 years ago

Update HTML classes in the audio and video shortcodes. props rfair404. fixes #24820.

Merges [24857] to the 3.6 branch.

Note: See TracTickets for help on using tickets.

Download in other formats: