WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#24821 closed task (blessed) (fixed)

Quiet jQuery Migrate

Reported by: nacin Owned by: nacin
Milestone: 3.6 Priority: normal
Severity: normal Version:
Component: Export Keywords:
Focuses: Cc:

Description

We need to minify jQuery and jQuery Migrate (and anything else). In the process, jQuery Migrate's warnings will automatically be silenced.

We could actually try to un-silence them for WP_DEBUG if we wanted to.

Change History (5)

#1 follow-up: @nacin
7 years ago

We could possibly just also bundle the un-minified jQuery Migrate file and use it when WP_DEBUG. I think that would actually be well worth the 16 KB.

#2 @nacin
7 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 24781:

Use production version of jQuery Migrate when not SCRIPT_DEBUG, which silences issues.

Minify jQuery as well. These were both unminified for ease of debugging.

fixes #24821.

#3 in reply to: ↑ 1 ; follow-up: @TobiasBg
7 years ago

Replying to nacin:

We could possibly just also bundle the un-minified jQuery Migrate file and use it when WP_DEBUG. I think that would actually be well worth the 16 KB.

Is that really that helpful, if jQuery ("core") is minified (which it is even with SCRIPT_DEBUG)?

#4 @nacin
7 years ago

In 24791:

jQuery.noConflict(). see [24781]. see #24821.

#5 in reply to: ↑ 3 @nacin
7 years ago

Replying to TobiasBg:

Replying to nacin:

We could possibly just also bundle the un-minified jQuery Migrate file and use it when WP_DEBUG. I think that would actually be well worth the 16 KB.

Is that really that helpful, if jQuery ("core") is minified (which it is even with SCRIPT_DEBUG)?

Yes. jQuery Migrate will print warnings (and backtraces) in the console. Any code that triggers it will be highlighted as a problem for how they use jQuery. The internals of jQuery are not really at issue.

Note: See TracTickets for help on using tickets.