Context Navigation

← Previous Ticket
Next Ticket →

#24826 closed enhancement (fixed)

Add __construct function to the "WP_Comment_Query" Class

Reported by:	ramiy	Owned by:	boonebgorges
Priority:	normal	Milestone:	4.2
Component:	Comments	Version:	3.5
Severity:	normal	Keywords:	has-patch commit 4.2-beta
Cc:		Focuses:

Description

Add PHP5 construct function to the comments query class, just like we have constructor functions on WP_Query and WP_User_Query classes.

Attachments (5)

comment.php.diff (3.1 KB ) - added by westonruter 13 years ago.
tests-comment-query.php.patch (1.1 KB ) - added by westonruter 13 years ago.
24826.diff (4.1 KB ) - added by westonruter 12 years ago.: Refreshed patch. PR: https://github.com/x-team/wordpress-develop/pull/24
24826.1.diff (4.2 KB ) - added by morganestes 11 years ago.: Refreshed patch
24826.2.diff (6.0 KB ) - added by morganestes 11 years ago.: Cleaned up and re-added docblocks to class methods that were split in 4.2.

Download all attachments as: .zip

Change History (24)

#1 @DrewAPicture
13 years ago

Cc xoodrew@… added
Version trunk → 3.1

@westonruter
13 years ago

Attachment comment.php.diff added

@westonruter
13 years ago

Attachment tests-comment-query.php.patch added

#2 @westonruter
13 years ago

Cc weston@… added
Keywords has-patch added; needs-patch removed
Severity major → normal
Version 3.1 → trunk

Add WP_Comment_Query::__construct() for parity with WP_Query::__construct()

Also:
Add WP_Comment_Query::get_comments() for parity with WP_Query::get_posts()
Add WP_Comment_Query::$comments for parity with WP_Query::$posts
Declare WP_Comment_Query::$query_vars which was previously implicit

Relates to #15032

Patches are also on GitHub at:
https://github.com/x-team/WordPress/tree/24826
https://github.com/x-team/WordPress/commit/db6105cbaf60ca20501fafea29b0f8277ed03cd3

Passes unit tests for comment group; also added a new test for the changes to WP_Comment_Query (attached).

Version 0, edited 13 years ago by westonruter (next)

#3 @SergeyBiryukov
13 years ago

Version trunk → 3.5

#4 @wonderboymusic
12 years ago

Keywords needs-refresh added; 2nd-opinion dev-feedback removed
Milestone Awaiting Review → Future Release

This does improve the class, but the patch currently explodes

@westonruter
12 years ago

Attachment 24826.diff added

Refreshed patch. PR: https://github.com/x-team/wordpress-develop/pull/24

#5 @westonruter
12 years ago

Keywords needs-refresh removed

In 24826.diff merged core patch and unit test patch into one, and fixed conflicts.

#6 @wonderboymusic
11 years ago

Milestone Future Release → 4.2

This ticket was mentioned in Slack in #core by drew. View the logs.

11 years ago

#8 @DrewAPicture
11 years ago

Keywords needs-refresh added

24826.diff needs a refresh.

@morganestes
11 years ago

Attachment 24826.1.diff added

Refreshed patch

#9 @morganestes
11 years ago

Keywords needs-refresh removed

#10 @DrewAPicture
11 years ago

Keywords commit added
Owner set to boonebgorges
Status new → reviewing

@morganestes: Thanks for the refresh. We should probably update the @since versions on WP_Comment_Query::get_comments() and the new constructor to 4.2.0. Barring that, I think we can move this for commit consideration.

@boonebgorges: Any chance you could review this?

@morganestes
11 years ago

Attachment 24826.2.diff added

Cleaned up and re-added docblocks to class methods that were split in 4.2.

#11 @boonebgorges
11 years ago

Yes, I can review. I would only feel comfortable moving forward if I had some time to review the documentation and some backward compatibility issues. If this needs to be committed today to make 4.2.0, let's punt. If it can go in sometime in the next week, let's keep it in 4.2.

This ticket was mentioned in Slack in #core by drew. View the logs.

11 years ago

#13 @DrewAPicture
11 years ago

Keywords 4.2-beta added
Owner changed from boonebgorges to DrewAPicture
Status reviewing → accepted

#14 @DrewAPicture
11 years ago

Owner changed from DrewAPicture to boonebgorges
Status accepted → assigned

#15 @boonebgorges
11 years ago

Resolution → fixed
Status assigned → closed

In 31793:

Improve method consistency in WP_Comment_Query.

Introduce a __construct() method, which can accept an array of query vars.
Move query logic out of query() method and into a new get_comments() method.
Ensure that $this->comments is set whenever get_comments() returns a value.
Introduce a parse_query() method, where query vars are parsed with default values and the 'parse_comment_query' action is fired.

These changes bring WP_Comment_Query syntax closer to that of WP_Query.

Props westonruter, morganestes, boonebgorges.
Fixes #24826.

#16 @DrewAPicture
11 years ago

Resolution fixed
Status closed → reopened

The hash notation should've been moved to the constructor as well.

#17 @DrewAPicture
11 years ago

Resolution → fixed
Status reopened → closed

In 31795:

Move the default arguments hash notation for WP_Comment_Query to the new constructor, where the argument definitions were moved in [31793].

Core style dictates that the default arguments should be documented in the same function or method where they are defined.

See [31793].
Fixes #24826.

#18 @rachelbaker
11 years ago

#16431 was marked as a duplicate.

#19 @DrewAPicture
10 years ago

In 37355:

Docs: Add a missing hook doc for the parse_comment_query hook, added in [31793].

Props flixos90.
See #24826. Fixes #36740.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#24826 closed enhancement (fixed)

Add __construct function to the "WP_Comment_Query" Class

Description

Attachments (5)

Change History (24)

#1 @DrewAPicture 13 years ago

@westonruter 13 years ago

@westonruter 13 years ago

#2 @westonruter 13 years ago

#3 @SergeyBiryukov 13 years ago

#4 @wonderboymusic 12 years ago

@westonruter 12 years ago

#5 @westonruter 12 years ago

#6 @wonderboymusic 11 years ago

This ticket was mentioned in ​Slack in #core by drew. ​View the logs. 11 years ago

#8 @DrewAPicture 11 years ago

@morganestes 11 years ago

#9 @morganestes 11 years ago

#10 @DrewAPicture 11 years ago

@morganestes 11 years ago

#11 @boonebgorges 11 years ago

This ticket was mentioned in ​Slack in #core by drew. ​View the logs. 11 years ago

#13 @DrewAPicture 11 years ago

#14 @DrewAPicture 11 years ago

#15 @boonebgorges 11 years ago

#16 @DrewAPicture 11 years ago

#17 @DrewAPicture 11 years ago

#18 @rachelbaker 11 years ago

#19 @DrewAPicture 10 years ago

Download in other formats:

#1 @DrewAPicture
13 years ago

@westonruter
13 years ago

@westonruter
13 years ago

#2 @westonruter
13 years ago

#3 @SergeyBiryukov
13 years ago

#4 @wonderboymusic
12 years ago

@westonruter
12 years ago

#5 @westonruter
12 years ago

#6 @wonderboymusic
11 years ago

This ticket was mentioned in Slack in #core by drew. View the logs.

11 years ago

#8 @DrewAPicture
11 years ago

@morganestes
11 years ago

#9 @morganestes
11 years ago

#10 @DrewAPicture
11 years ago

@morganestes
11 years ago

#11 @boonebgorges
11 years ago

This ticket was mentioned in Slack in #core by drew. View the logs.

11 years ago

#13 @DrewAPicture
11 years ago

#14 @DrewAPicture
11 years ago

#15 @boonebgorges
11 years ago

#16 @DrewAPicture
11 years ago

#17 @DrewAPicture
11 years ago

#18 @rachelbaker
11 years ago

#19 @DrewAPicture
10 years ago