WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#24838 closed defect (bug) (fixed)

Dashboard Blog text remains in help text but setting has been removed, get_dashboard_blog function seems to be deprecated but is not marked as such

Reported by: nickciske Owned by: ryan
Milestone: 3.7 Priority: normal
Severity: minor Version: 3.1
Component: Multisite Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

  1. Go to Network Settings on a multisite install.
  2. Open the Help pane.
  3. You'll see:

Dashboard Site is an option to give a site to users who do not have a site on the system. Their default role is Subscriber, but that default can be changed.

However, there is no longer a Dashboard Site field in the settings.

Additionally, it seems that get_dashboard_blog (which is the only code that appears to use this option) is not yet deprecated, despite being effectively removed 3 years ago in the 3.0 transition from MU to MS.

Related: #14696

Attachments (4)

24838-help.diff (1.7 KB) - added by sillybean 6 years ago.
Remove help text for obsolete network settings
24838-deprecate.diff (1.4 KB) - added by sillybean 6 years ago.
Deprecate unused get_dashboard_blog() function
24838.patch (3.2 KB) - added by ocean90 6 years ago.
24838.2.patch (3.2 KB) - added by ocean90 6 years ago.

Download all attachments as: .zip

Change History (14)

#1 @SergeyBiryukov
6 years ago

  • Component changed from General to Help/About
  • Keywords needs-patch added
  • Version set to 3.1

#2 @nickciske
6 years ago

  • Component changed from Help/About to Multisite

@sillybean
6 years ago

Remove help text for obsolete network settings

#3 @sillybean
6 years ago

  • Cc steph@… added
  • Keywords has-patch 2nd-opinion added; needs-patch removed

#4 @ocean90
6 years ago

  • Milestone changed from Awaiting Review to 3.7

#5 @SergeyBiryukov
6 years ago

get_dashboard_blog() should probably be moved to ms-deprecated.php rather than deprecated.php.

@sillybean
6 years ago

Deprecate unused get_dashboard_blog() function

#6 @sillybean
6 years ago

Quite right. Patch updated.

#7 @ocean90
6 years ago

  • Keywords commit added; 2nd-opinion removed

The mentioned "notice feed" is gone too, see #14587.

@ocean90
6 years ago

#8 @ocean90
6 years ago

24838.patch

  • Uses @deprecated 3.1.0
  • Removes alternative function
  • Combines 24838-deprecate.diff​ and 24838-help.diff​

#9 @nacin
6 years ago

I like 24838.patch. More clear what is going on, I think. Perhaps just add a comment along the lines of: "Dashboard blog functionality was removed in WordPress 3.1, replaced by the user admin."

@ocean90
6 years ago

#10 @ryan
6 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In 24993:

Deprecate get_dashboard_blog().
Remove contextual help for Dashboard Site from the network settings screen.

Props sillybean, ocean90
fixes #24838

Note: See TracTickets for help on using tickets.