WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 9 months ago

#24840 closed defect (bug) (fixed)

Reinstate 'label' property of nav menu items

Reported by: johnbillion Owned by: markjaquith
Milestone: 3.6 Priority: normal
Severity: normal Version: 3.5
Component: Menus Keywords: has-patch commit
Focuses: Cc:

Description

Using the nav_menu_items_{$post_type} filter, a plugin can add to the list of nav menu items available on the Appearance -> Menus screen.

Prior to [22234] a nav menu item could include a 'label' property and this would be used as the item title when shown in the list, allowing the actual menu item to use a different title. That changeset removed the use of the label property.

One of my plugins uses the 'label' property for this purpose. It'd be nice to reinstate it please and thank you.

Attachments (1)

24840.patch (728 bytes) - added by johnbillion 9 months ago.

Download all attachments as: .zip

Change History (4)

johnbillion9 months ago

comment:1 johnbillion9 months ago

  • Keywords has-patch added

comment:2 nacin9 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.6

Looks good. Marking for 3.6 as this was a 3.4 -> 3.5 regression.

comment:3 markjaquith9 months ago

  • Owner set to markjaquith
  • Resolution set to fixed
  • Status changed from new to closed

In 24798:

Reinstate 'label' property of nav menu items. Fixes a regression from [22234].

Fixes #24840. Props johnbillion.

Note: See TracTickets for help on using tickets.