Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#24840 closed defect (bug) (fixed)

Reinstate 'label' property of nav menu items

Reported by: johnbillion Owned by: markjaquith
Priority: normal Milestone: 3.6
Component: Menus Version: 3.5
Severity: normal Keywords: has-patch commit
Cc: Focuses:

Description

Using the nav_menu_items_{$post_type} filter, a plugin can add to the list of nav menu items available on the Appearance -> Menus screen.

Prior to [22234] a nav menu item could include a 'label' property and this would be used as the item title when shown in the list, allowing the actual menu item to use a different title. That changeset removed the use of the label property.

One of my plugins uses the 'label' property for this purpose. It'd be nice to reinstate it please and thank you.

Attachments (1)

24840.patch​ (728 bytes ) - added by johnbillion 13 years ago.

Download all attachments as: .zip

Change History (4)

@johnbillion
13 years ago

#1 @johnbillion
13 years ago

  • Keywords has-patch added

#2 @nacin
13 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 3.6

Looks good. Marking for 3.6 as this was a 3.4 -> 3.5 regression.

#3 @markjaquith
13 years ago

  • Owner set to markjaquith
  • Resolution → fixed
  • Status new → closed

In 24798:

Reinstate 'label' property of nav menu items. Fixes a regression from [22234].

Fixes #24840. Props johnbillion.

Note: See TracTickets for help on using tickets.