Context Navigation

← Previous Ticket
Next Ticket →

#24842 closed defect (bug) (fixed)

Incorrect @uses in docblock for update_post_caches()

Reported by:	jdgrimes	Owned by:
Priority:	normal	Milestone:	3.7
Component:	Inline Docs	Version:
Severity:	minor	Keywords:	has-patch commit 3.7-early
Cc:		Focuses:

Description

The docblock for update_post_caches() includes this line:

* @uses $wpdb

However, it does not contain any references to $wpdb. This appears to have been the case since [6379]

Attachments (2)

24842.patch (360 bytes ) - added by jdgrimes 13 years ago.: Removes the offending line from the docblock comment
24842.2.diff (2.5 KB ) - added by JustinSainton 13 years ago.

Download all attachments as: .zip

Change History (7)

@jdgrimes
13 years ago

Attachment 24842.patch added

Removes the offending line from the docblock comment

#1 @SergeyBiryukov
13 years ago

Perhaps @uses $wpdb should be removed for all the functions that don't use it directly:

get_post()
get_posts()
add_post_meta()
delete_post_meta()
get_post_meta()
update_post_meta()
delete_post_meta_by_key()
get_enclosed()
update_post_caches()
update_postmeta_cache()

@JustinSainton
13 years ago

Attachment 24842.2.diff added

#2 @JustinSainton
13 years ago

24842.2.diff removes @uses $wpdb on all suggested functions.

#3 @SergeyBiryukov
13 years ago

Keywords commit 3.7-early added

#4 @mdawaffe
13 years ago

Resolution → fixed
Status new → closed

Fixed in [24807]. (I'm awesome at committing.)

#5 @helen
13 years ago

Milestone Awaiting Review → 3.7

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#24842 closed defect (bug) (fixed)

Incorrect @uses in docblock for update_post_caches()

Description

Attachments (2)

Change History (7)

@jdgrimes 13 years ago

#1 @SergeyBiryukov 13 years ago

@JustinSainton 13 years ago

#2 @JustinSainton 13 years ago

#3 @SergeyBiryukov 13 years ago

#4 @mdawaffe 13 years ago

#5 @helen 13 years ago