WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#24842 closed defect (bug) (fixed)

Incorrect @uses in docblock for update_post_caches()

Reported by: jdgrimes Owned by:
Milestone: 3.7 Priority: normal
Severity: minor Version:
Component: Inline Docs Keywords: has-patch commit 3.7-early
Focuses: Cc:

Description

The docblock for update_post_caches() includes this line:

* @uses $wpdb

However, it does not contain any references to $wpdb. This appears to have been the case since [6379]

Attachments (2)

24842.patch (360 bytes) - added by jdgrimes 8 years ago.
Removes the offending line from the docblock comment
24842.2.diff (2.5 KB) - added by JustinSainton 8 years ago.

Download all attachments as: .zip

Change History (7)

@jdgrimes
8 years ago

Removes the offending line from the docblock comment

#1 @SergeyBiryukov
8 years ago

Perhaps @uses $wpdb should be removed for all the functions that don't use it directly:

  • get_post()
  • get_posts()
  • add_post_meta()
  • delete_post_meta()
  • get_post_meta()
  • update_post_meta()
  • delete_post_meta_by_key()
  • get_enclosed()
  • update_post_caches()
  • update_postmeta_cache()

#2 @JustinSainton
8 years ago

24842.2.diff removes @uses $wpdb on all suggested functions.

#3 @SergeyBiryukov
8 years ago

  • Keywords commit 3.7-early added

#4 @mdawaffe
8 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [24807]. (I'm awesome at committing.)

#5 @helen
8 years ago

  • Milestone changed from Awaiting Review to 3.7
Note: See TracTickets for help on using tickets.