Make WordPress Core

Opened 16 years ago

Closed 15 years ago

#2485 closed enhancement (fixed)

No flexibility in comments RSS feed

Reported by: mdawaffe's profile mdawaffe Owned by: rob1n's profile rob1n
Milestone: 2.2 Priority: normal
Severity: normal Version: 2.1
Component: General Keywords: has-patch needs-testing
Focuses: Cc:

Description

wp-commentsrss2.php does not give any flexibility in determining what sorts of comments should be displayed. All we get is the feed for individual posts/pages or for the whole site. Additionally, no filtration is allowed.

The attached hangs on the coat tails of WP_Query. Comment feeds for time, category, search, post, page, and the main site should all work. Filtration on JOIN and WHERE is allowed.

I've not done any benchmarking comparing this patch vs. the old system.

Attachments (4)

commentfeed.diff (8.0 KB) - added by mdawaffe 16 years ago.
Allows for more flexibility in comment feeds
2485.diff (9.5 KB) - added by rob1n 15 years ago.
2485.2.diff (11.8 KB) - added by rob1n 15 years ago.
Adds have_comment(), the_comment and a bunch of WP_Query stuff, including the original patch. *needs testing*
2485.3.diff (16.2 KB) - added by mdawaffe 15 years ago.

Download all attachments as: .zip

Change History (15)

@mdawaffe
16 years ago

Allows for more flexibility in comment feeds

#2 @coppit
16 years ago

  • Cc coppit added

#3 @mdawaffe
16 years ago

  • Milestone set to 2.1

Related: #2840.

#4 @matt
16 years ago

  • Milestone changed from 2.1 to 2.2

#5 @rob1n
15 years ago

  • Keywords bg|has-patch bg|2nd-opinion removed
  • Owner changed from mdawaffe to rob1n
  • Status changed from new to assigned

#6 @rob1n
15 years ago

  • Version changed from 2.0.1 to 2.1

Working on refreshing old patch.

@rob1n
15 years ago

#7 @rob1n
15 years ago

  • Keywords has-patch added

@rob1n
15 years ago

Adds have_comment(), the_comment and a bunch of WP_Query stuff, including the original patch. *needs testing*

#8 @rob1n
15 years ago

  • Keywords needs-testing added

@mdawaffe
15 years ago

#9 @mdawaffe
15 years ago

2485.3.diff

  1. All of rob1n's 2485.2.diff (rob1n: please verify)
  2. Get rid of some parse errors.
  3. Get rid of have_posts() (I don't think it's necessary) and use have_comments().
  4. Somewhat better comments feed titles.

#10 @rob1n
15 years ago

Looks good. I think this is ready for commit?

#11 @ryan
15 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [4934]) Comment feeds everywhere. Props mdawaffe and rob1n. fixes #2485

Note: See TracTickets for help on using tickets.